Addressing some of the feedback. Work still pending

Author: raulgarciamsft

csharp/ql/src/experimental/Security Features/JsonWebTokenHandler/JsonWebTokenHandlerLib.qll

@@ -189,7 +189,7 @@ class CallableAlwaysReturnsTrueHigherPrecision extends CallableAlwaysReturnsTrue
       )
       or
       exists(LambdaExpr le, Call call, CallableAlwaysReturnsTrueHigherPrecision cat | this = le |
-        call = le.getExpressionBody() and
+        le.canReturn(call) and
         cat.getACall() = call
       )
     )
@@ -217,7 +217,7 @@ class TokenValidationParametersPropertyWriteToValidationDelegatedIssuerValidator
 private class CallableReturnsStringAndArg0IsString extends Callable {
   CallableReturnsStringAndArg0IsString() {
     this.getReturnType() instanceof StringType and
-    this.getParameter(0).getType().toString() = "String"
+    this.getParameter(0).getType() instanceof StringType
   }
 }
 
@@ -227,7 +227,7 @@ private class CallableReturnsStringAndArg0IsString extends Callable {
 class CallableAlwaysReturnsParameter0 extends CallableReturnsStringAndArg0IsString {
   CallableAlwaysReturnsParameter0() {
     forall(ReturnStmt rs | rs.getEnclosingCallable() = this |
-      rs.getChild(0) = this.getParameter(0).getAnAccess()
+      rs.getExpr() = this.getParameter(0).getAnAccess()
     ) and
     exists(ReturnStmt rs | rs.getEnclosingCallable() = this)
     or

csharp/ql/test/experimental/Security Features/JsonWebTokenHandler/security-validation-disabled.expected

@@ -1,5 +1,5 @@
-| security-validation-disabled-test.cs:31:34:31:38 | false | The security sensitive property $@ is being disabled by the followign value: $@. | security-validation-disabled-test.cs:31:17:31:30 | access to property ValidateIssuer | ValidateIssuer | security-validation-disabled-test.cs:31:34:31:38 | false | false |
-| security-validation-disabled-test.cs:32:36:32:40 | false | The security sensitive property $@ is being disabled by the followign value: $@. | security-validation-disabled-test.cs:32:17:32:32 | access to property ValidateAudience | ValidateAudience | security-validation-disabled-test.cs:32:36:32:40 | false | false |
-| security-validation-disabled-test.cs:33:36:33:40 | false | The security sensitive property $@ is being disabled by the followign value: $@. | security-validation-disabled-test.cs:33:17:33:32 | access to property ValidateLifetime | ValidateLifetime | security-validation-disabled-test.cs:33:36:33:40 | false | false |
-| security-validation-disabled-test.cs:34:41:34:45 | false | The security sensitive property $@ is being disabled by the followign value: $@. | security-validation-disabled-test.cs:34:17:34:37 | access to property RequireExpirationTime | RequireExpirationTime | security-validation-disabled-test.cs:34:41:34:45 | false | false |
-| security-validation-disabled-test.cs:37:35:37:39 | false | The security sensitive property $@ is being disabled by the followign value: $@. | security-validation-disabled-test.cs:37:17:37:31 | access to property RequireAudience | RequireAudience | security-validation-disabled-test.cs:37:35:37:39 | false | false |
+| security-validation-disabled-test.cs:31:34:31:38 | false | The security sensitive property $@ is being disabled by the following value: $@. | security-validation-disabled-test.cs:31:17:31:30 | access to property ValidateIssuer | ValidateIssuer | security-validation-disabled-test.cs:31:34:31:38 | false | false |
+| security-validation-disabled-test.cs:32:36:32:40 | false | The security sensitive property $@ is being disabled by the following value: $@. | security-validation-disabled-test.cs:32:17:32:32 | access to property ValidateAudience | ValidateAudience | security-validation-disabled-test.cs:32:36:32:40 | false | false |
+| security-validation-disabled-test.cs:33:36:33:40 | false | The security sensitive property $@ is being disabled by the following value: $@. | security-validation-disabled-test.cs:33:17:33:32 | access to property ValidateLifetime | ValidateLifetime | security-validation-disabled-test.cs:33:36:33:40 | false | false |
+| security-validation-disabled-test.cs:34:41:34:45 | false | The security sensitive property $@ is being disabled by the following value: $@. | security-validation-disabled-test.cs:34:17:34:37 | access to property RequireExpirationTime | RequireExpirationTime | security-validation-disabled-test.cs:34:41:34:45 | false | false |
+| security-validation-disabled-test.cs:37:35:37:39 | false | The security sensitive property $@ is being disabled by the following value: $@. | security-validation-disabled-test.cs:37:17:37:31 | access to property RequireAudience | RequireAudience | security-validation-disabled-test.cs:37:35:37:39 | false | false |