Skip to content

Commit 960e9db

Browse files
Jami Cogswellatorralba
authored andcommitted
add missing expectation to tests
1 parent 1857a5d commit 960e9db

File tree

1 file changed

+14
-2
lines changed

1 file changed

+14
-2
lines changed

java/ql/test/library-tests/frameworks/android/intent/TestStartActivityToGetIntent.java

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,29 @@ static void sink(Object sink) {}
1212

1313
public void test(Context ctx, Activity act) {
1414

15-
// test methods that start an activity
15+
// test all methods that start an activity
1616
{
1717
Intent intent = new Intent(null, SomeActivity.class);
1818
intent.putExtra("data", (String) source("ctx-start"));
1919
ctx.startActivity(intent);
2020
}
21+
{
22+
Intent intent = new Intent(null, SomeActivity.class);
23+
intent.putExtra("data", (String) source("ctx-start-acts"));
24+
Intent[] intents = new Intent[] {intent};
25+
ctx.startActivities(intents);
26+
}
2127
{
2228
Intent intent = new Intent(null, SomeActivity.class);
2329
intent.putExtra("data", (String) source("act-start"));
2430
act.startActivity(intent);
2531
}
32+
{
33+
Intent intent = new Intent(null, SomeActivity.class);
34+
intent.putExtra("data", (String) source("act-start-acts"));
35+
Intent[] intents = new Intent[] {intent};
36+
act.startActivities(intents);
37+
}
2638
{
2739
Intent intent = new Intent(null, SomeActivity.class);
2840
intent.putExtra("data", (String) source("start-for-result"));
@@ -67,7 +79,7 @@ public void test(Context ctx, Activity act) {
6779
static class SomeActivity extends Activity {
6880

6981
public void test() {
70-
sink(getIntent().getStringExtra("data")); // $ hasValueFlow=ctx-start hasValueFlow=act-start hasValueFlow=start-for-result hasValueFlow=start-if-needed hasValueFlow=start-matching hasValueFlow=start-from-child hasValueFlow=start-from-frag hasValueFlow=4-arg
82+
sink(getIntent().getStringExtra("data")); // $ hasValueFlow=ctx-start hasValueFlow=act-start hasValueFlow=start-for-result hasValueFlow=start-if-needed hasValueFlow=start-matching hasValueFlow=start-from-child hasValueFlow=start-from-frag hasValueFlow=4-arg MISSING: hasValueFlow=ctx-start-acts hasValueFlow=act-start-acts
7183
}
7284

7385
}

0 commit comments

Comments
 (0)