Swift: remove check for inout params in SSA gen

rdmarsh2 · web-flow · commit 946d0358c95b · 2022-06-23T15:59:34.000Z
This check is unnecessary since it's enforced by the compiler, and is
causing a bad join order.
diff --git a/swift/ql/lib/codeql/swift/dataflow/internal/SsaImplSpecific.qll b/swift/ql/lib/codeql/swift/dataflow/internal/SsaImplSpecific.qll
@@ -32,7 +32,6 @@ predicate variableWrite(BasicBlock bb, int i, SourceVariable v, boolean certain)
   exists(CallExpr call, Argument arg |
     arg.getExpr().(InOutExpr).getSubExpr() = v.getAnAccess() and
     call.getAnArgument() = arg and
-    call.getStaticTarget().getParam(arg.getIndex()).isInout() and
     bb.getNode(i).getNode().asAstNode() = call and
     certain = false
   )

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,6 @@ predicate variableWrite(BasicBlock bb, int i, SourceVariable v, boolean certain)`
`32`	`32`	`exists(CallExpr call, Argument arg \|`
`33`	`33`	`arg.getExpr().(InOutExpr).getSubExpr() = v.getAnAccess() and`
`34`	`34`	`call.getAnArgument() = arg and`
`35`		`- call.getStaticTarget().getParam(arg.getIndex()).isInout() and`
`36`	`35`	`bb.getNode(i).getNode().asAstNode() = call and`
`37`	`36`	`certain = false`
`38`	`37`	`)`