bind the result in JsonValue::getBooleanValue

erik-krogh · erik-krogh · commit 92d1c84f051e · 2022-06-14T13:22:09.000+02:00
diff --git a/javascript/ql/lib/semmle/javascript/JSON.qll b/javascript/ql/lib/semmle/javascript/JSON.qll
@@ -54,7 +54,9 @@ class JsonValue extends @json_value, Locatable {
   int getIntValue() { result = this.(JsonNumber).getValue().toInt() }
 
   /** If this is a boolean constant, gets its boolean value. */
-  boolean getBooleanValue() { result.toString() = this.(JsonBoolean).getValue() }
+  boolean getBooleanValue() {
+    result.toString() = this.(JsonBoolean).getValue() and result = [true, false]
+  }
 
   override string getAPrimaryQlClass() { result = "JsonValue" }
 }

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,9 @@ class JsonValue extends @json_value, Locatable {`
`54`	`54`	`int getIntValue() { result = this.(JsonNumber).getValue().toInt() }`
`55`	`55`
`56`	`56`	`/** If this is a boolean constant, gets its boolean value. */`
`57`		`- boolean getBooleanValue() { result.toString() = this.(JsonBoolean).getValue() }`
	`57`	`+ boolean getBooleanValue() {`
	`58`	`+ result.toString() = this.(JsonBoolean).getValue() and result = [true, false]`
	`59`	`+ }`
`58`	`60`
`59`	`61`	`override string getAPrimaryQlClass() { result = "JsonValue" }`
`60`	`62`	`}`