Swift: Remove special case (no longer required).

geoffw0 · geoffw0 · commit 92a927efa72a · 2022-09-01T08:53:51.000+01:00
diff --git a/swift/ql/src/queries/Security/CWE-311/CleartextStorageDatabase.ql b/swift/ql/src/queries/Security/CWE-311/CleartextStorageDatabase.ql
@@ -96,14 +96,6 @@ class CleartextStorageConfig extends TaintTracking::Configuration {
     // any default implicit reads
     super.allowImplicitRead(node, c)
   }
-
-  override predicate isAdditionalTaintStep(DataFlow::Node node1, DataFlow::Node node2) {
-    // flow through assignment (!) TODO: we really shouldn't need this as a special case
-    exists(AssignExpr ae |
-      node1.asExpr() = ae.getSource() and
-      node2.asExpr() = ae.getDest()
-    )
-  }
 }
 
 from CleartextStorageConfig config, DataFlow::PathNode sourceNode, DataFlow::PathNode sinkNode

Original file line number	Diff line number	Diff line change
`@@ -96,14 +96,6 @@ class CleartextStorageConfig extends TaintTracking::Configuration {`
`96`	`96`	`// any default implicit reads`
`97`	`97`	`super.allowImplicitRead(node, c)`
`98`	`98`	`}`
`99`		`-`
`100`		`- override predicate isAdditionalTaintStep(DataFlow::Node node1, DataFlow::Node node2) {`
`101`		`- // flow through assignment (!) TODO: we really shouldn't need this as a special case`
`102`		`- exists(AssignExpr ae \|`
`103`		`- node1.asExpr() = ae.getSource() and`
`104`		`- node2.asExpr() = ae.getDest()`
`105`		`- )`
`106`		`- }`
`107`	`99`	`}`
`108`	`100`
`109`	`101`	`from CleartextStorageConfig config, DataFlow::PathNode sourceNode, DataFlow::PathNode sinkNode`