deprecate internal predicate that was never used

erik-krogh · erik-krogh · commit 8eefa4c1b0a4 · 2022-09-20T12:39:41.000+02:00
diff --git a/java/ql/lib/semmle/code/java/controlflow/Guards.qll b/java/ql/lib/semmle/code/java/controlflow/Guards.qll
@@ -218,12 +218,12 @@ predicate guardControls_v1(Guard guard, BasicBlock controlled, boolean branch) {
 }
 
 /**
- * INTERNAL: Use `Guards.controls` instead.
+ * DEPRECATED: Use `Guards.controls` instead.
  *
  * Holds if `guard.controls(controlled, branch)`, except this doesn't rely on
  * RangeAnalysis.
  */
-predicate guardControls_v2(Guard guard, BasicBlock controlled, boolean branch) {
+deprecated predicate guardControls_v2(Guard guard, BasicBlock controlled, boolean branch) {
   guard.directlyControls(controlled, branch)
   or
   exists(Guard g, boolean b |

Original file line number	Diff line number	Diff line change
`@@ -218,12 +218,12 @@ predicate guardControls_v1(Guard guard, BasicBlock controlled, boolean branch) {`
`218`	`218`	`}`
`219`	`219`
`220`	`220`	`/**`
`221`		- * INTERNAL: Use `Guards.controls` instead.
	`221`	+ * DEPRECATED: Use `Guards.controls` instead.
`222`	`222`	`*`
`223`	`223`	* Holds if `guard.controls(controlled, branch)`, except this doesn't rely on
`224`	`224`	`* RangeAnalysis.`
`225`	`225`	`*/`
`226`		`-predicate guardControls_v2(Guard guard, BasicBlock controlled, boolean branch) {`
	`226`	`+deprecated predicate guardControls_v2(Guard guard, BasicBlock controlled, boolean branch) {`
`227`	`227`	`guard.directlyControls(controlled, branch)`
`228`	`228`	`or`
`229`	`229`	`exists(Guard g, boolean b \|`