SSA: Create a new shared library pack and move implementation there

Author: hvitved

config/identical-files.json

@@ -460,12 +460,6 @@
     "javascript/ql/lib/IDEContextual.qll",
     "python/ql/lib/analysis/IDEContextual.qll"
   ],
-  "SSA C#": [
-    "csharp/ql/lib/semmle/code/csharp/dataflow/internal/SsaImplCommon.qll",
-    "ruby/ql/lib/codeql/ruby/dataflow/internal/SsaImplCommon.qll",
-    "cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaImplCommon.qll",
-    "swift/ql/lib/codeql/swift/dataflow/internal/SsaImplCommon.qll"
-  ],
   "CryptoAlgorithms Python/JS/Ruby": [
     "javascript/ql/lib/semmle/javascript/security/CryptoAlgorithms.qll",
     "python/ql/lib/semmle/python/concepts/CryptoAlgorithms.qll",

cpp/ql/lib/qlpack.yml

@@ -5,3 +5,5 @@ dbscheme: semmlecode.cpp.dbscheme
 extractor: cpp
 library: true
 upgrades: upgrades
+dependencies:
+  codeql/shared-all: "*"

cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaInternals.qll

@@ -4,7 +4,7 @@ private import DataFlowUtil
 private import DataFlowImplCommon as DataFlowImplCommon
 private import semmle.code.cpp.models.interfaces.Allocation as Alloc
 private import semmle.code.cpp.models.interfaces.DataFlow as DataFlow
-private import SsaImplCommon as SsaImplCommon
+private import codeql.shared.dataflow.Ssa as SsaImplCommon
 
 private module SourceVariables {
   private newtype TSourceVariable =

csharp/ql/lib/qlpack.yml

@@ -5,3 +5,5 @@ dbscheme: semmlecode.csharp.dbscheme
 extractor: csharp
 library: true
 upgrades: upgrades
+dependencies:
+  codeql/shared-all: "*"

csharp/ql/lib/semmle/code/cil/internal/SsaImpl.qll

@@ -1,5 +1,5 @@
 private import cil
-private import semmle.code.csharp.dataflow.internal.SsaImplCommon as SsaImplCommon
+private import codeql.shared.dataflow.Ssa as SsaImplCommon
 
 private module SsaInput implements SsaImplCommon::InputSig {
   class BasicBlock = CIL::BasicBlock;

csharp/ql/lib/semmle/code/csharp/controlflow/internal/PreSsa.qll

@@ -9,7 +9,7 @@ module PreSsa {
   private import AssignableDefinitions
   private import semmle.code.csharp.controlflow.internal.ControlFlowGraphImpl
   private import semmle.code.csharp.controlflow.internal.PreBasicBlocks as PreBasicBlocks
-  private import semmle.code.csharp.dataflow.internal.SsaImplCommon as SsaImplCommon
+  private import codeql.shared.dataflow.Ssa as SsaImplCommon
 
   private predicate definitionAt(
     AssignableDefinition def, SsaInput::BasicBlock bb, int i, SsaInput::SourceVariable v

csharp/ql/lib/semmle/code/csharp/dataflow/internal/BaseSSA.qll

@@ -5,7 +5,7 @@ import csharp
  */
 module BaseSsa {
   private import AssignableDefinitions
-  private import semmle.code.csharp.dataflow.internal.SsaImplCommon as SsaImplCommon
+  private import codeql.shared.dataflow.Ssa as SsaImplCommon
 
   /**
    * Holds if the `i`th node of basic block `bb` is assignable definition `def`,

csharp/ql/lib/semmle/code/csharp/dataflow/internal/SsaImpl.qll

@@ -3,7 +3,7 @@
  */
 
 import csharp
-private import SsaImplCommon as SsaImplCommon
+private import codeql.shared.dataflow.Ssa as SsaImplCommon
 private import AssignableDefinitions
 
 private module SsaInput implements SsaImplCommon::InputSig {