Skip to content

Commit 8ca529e

Browse files
committed
Swift: make Element::resolve final
One should only override `getResolveStep` (or `convertsFrom` for `Expr` classes), as otherwise the resolution/conversion becomes inconsitent.
1 parent d14eab8 commit 8ca529e

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

swift/codegen/templates/ql_class.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ class {{name}}Base extends {{db_id}}{{#bases}}, {{.}}{{/bases}} {
1414

1515
{{name}}Base getResolveStep() { none() } // overridden by subclasses
1616

17-
{{name}}Base resolve() {
17+
final {{name}}Base resolve() {
1818
not exists(getResolveStep()) and result = this
1919
or
2020
result = getResolveStep().resolve()

swift/ql/lib/codeql/swift/generated/Element.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ class ElementBase extends @element {
88

99
ElementBase getResolveStep() { none() } // overridden by subclasses
1010

11-
ElementBase resolve() {
11+
final ElementBase resolve() {
1212
not exists(getResolveStep()) and result = this
1313
or
1414
result = getResolveStep().resolve()

0 commit comments

Comments
 (0)