Skip to content

Commit 897d5c9

Browse files
jorgectfyoff
andauthored
Apply suggestions from code review
Co-authored-by: yoff <lerchedahl@gmail.com>
1 parent e577a0e commit 897d5c9

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

python/ql/src/experimental/semmle/python/frameworks/Django.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ private module ExperimentalPrivateDjango {
190190
}
191191
}
192192

193-
module email {
193+
module Email {
194194
/** https://docs.djangoproject.com/en/3.2/topics/email/ */
195195
private API::Node djangoMail() {
196196
result = API::moduleImport("django").getMember("core").getMember("mail")

python/ql/src/experimental/semmle/python/frameworks/Sendgrid.qll

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ private module Sendgrid {
2020
/** Gets a reference to `sendgrid.helpers.mail.Mail` */
2121
private API::Node sendgridMailInstance() { result = sendgridMailHelper().getMember("Mail") }
2222

23-
/** Gets a call to `sendgrid.helpers.mail.Mail()`. */
24-
private DataFlow::CallCfgNode sendgridMailCall() { result = sendgridMailInstance().getACall() }
2523

2624
/** Gets a reference to a `SendGridAPIClient` instance. */
2725
private API::Node sendgridApiClient() {
@@ -137,7 +135,7 @@ private module Sendgrid {
137135
or
138136
exists(KeyValuePair footer, Dict generalDict, KeyValuePair enablePair, KeyValuePair htmlPair |
139137
footer.getKey().(StrConst).getText() = ["footer", "subscription_tracking"] and
140-
footer.getValue().(Dict) = generalDict and
138+
footer.getValue() = generalDict and
141139
// check footer is enabled
142140
enablePair.getKey().(StrConst).getText() = "enable" and
143141
exists(enablePair.getValue().(True)) and

python/ql/src/experimental/semmle/python/libraries/FlaskMail.qll

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ private module FlaskMail {
1818
/** Gets a reference to `flask_mail.Mail()`, `flask_sendmail.Mail()` and `flask.ext.sendmail.Mail()`. */
1919
private API::Node flaskMailInstance() { result = flaskMail().getMember("Mail").getReturn() }
2020

21-
/** Gets a reference to `flask_mail.Message`, `flask_sendmail.Message` and `flask.ext.sendmail.Message`. */
22-
private API::Node flaskMessageInstance() { result = flaskMail().getMember("Message") }
2321

2422
/**
2523
* Gets a call to `mail.send()`.

0 commit comments

Comments
 (0)