Swift: Apply another code review suggestion.

geoffw0 · geoffw0 · commit 873c62ef78b8 · 2022-08-03T18:16:01.000+01:00
diff --git a/swift/ql/src/queries/Security/CWE-079/UnsafeWebViewFetch.ql b/swift/ql/src/queries/Security/CWE-079/UnsafeWebViewFetch.ql
@@ -137,7 +137,7 @@ where
     message = "Tainted data is used in a WebView fetch without restricting the base URL."
     or
     // base URL is tainted
-    config.hasFlow(_, any(DataFlow::Node n | n.asExpr() = sink.getBaseUrl())) and
+    config.hasFlowToExpr(sink.getBaseUrl()) and
     message = "Tainted data is used in a WebView fetch with a tainted base URL."
   )
 select sink, sourceNode, sinkNode, message

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,7 @@ where`
`137`	`137`	`message = "Tainted data is used in a WebView fetch without restricting the base URL."`
`138`	`138`	`or`
`139`	`139`	`// base URL is tainted`
`140`		`- config.hasFlow(_, any(DataFlow::Node n \| n.asExpr() = sink.getBaseUrl())) and`
	`140`	`+ config.hasFlowToExpr(sink.getBaseUrl()) and`
`141`	`141`	`message = "Tainted data is used in a WebView fetch with a tainted base URL."`
`142`	`142`	`)`
`143`	`143`	`select sink, sourceNode, sinkNode, message`