Add tests and stubs for the new sources and flow steps

Author: atorralba

java/ql/lib/semmle/code/java/frameworks/android/WebView.qll

@@ -81,17 +81,17 @@ private class WebkitSourceModels extends SourceModelCsv {
   override predicate row(string row) {
     row =
       [
-        "android.webkit;WebResourceRequest;true;doUpdateVisitedHistory;;;Parameter[1];remote",
-        "android.webkit;WebResourceRequest;true;onLoadResource;;;Parameter[1];remote",
-        "android.webkit;WebResourceRequest;true;onPageCommitVisible;;;Parameter[1];remote",
-        "android.webkit;WebResourceRequest;true;onPageFinished;;;Parameter[1];remote",
-        "android.webkit;WebResourceRequest;true;onPageStarted;;;Parameter[1];remote",
-        "android.webkit;WebResourceRequest;true;onReceivedError;(WebView,int,String,String);;Parameter[3];remote",
-        "android.webkit;WebResourceRequest;true;onReceivedError;(WebView,WebResourceRequest,WebResourceError);;Parameter[1];remote",
-        "android.webkit;WebResourceRequest;true;onReceivedHttpError;;;Parameter[1];remote",
-        "android.webkit;WebResourceRequest;true;onSafeBrowsingHit;;;Parameter[1];remote",
-        "android.webkit;WebResourceRequest;true;shouldInterceptRequest;;;Parameter[1];remote",
-        "android.webkit;WebResourceRequest;true;shouldOverrideUrlLoading;;;Parameter[1];remote"
+        "android.webkit;WebViewClient;true;doUpdateVisitedHistory;;;Parameter[1];remote",
+        "android.webkit;WebViewClient;true;onLoadResource;;;Parameter[1];remote",
+        "android.webkit;WebViewClient;true;onPageCommitVisible;;;Parameter[1];remote",
+        "android.webkit;WebViewClient;true;onPageFinished;;;Parameter[1];remote",
+        "android.webkit;WebViewClient;true;onPageStarted;;;Parameter[1];remote",
+        "android.webkit;WebViewClient;true;onReceivedError;(WebView,int,String,String);;Parameter[3];remote",
+        "android.webkit;WebViewClient;true;onReceivedError;(WebView,WebResourceRequest,WebResourceError);;Parameter[1];remote",
+        "android.webkit;WebViewClient;true;onReceivedHttpError;;;Parameter[1];remote",
+        "android.webkit;WebViewClient;true;onSafeBrowsingHit;;;Parameter[1];remote",
+        "android.webkit;WebViewClient;true;shouldInterceptRequest;;;Parameter[1];remote",
+        "android.webkit;WebViewClient;true;shouldOverrideUrlLoading;;;Parameter[1];remote"
       ]
   }
 }

java/ql/test/library-tests/frameworks/android/flow-steps/Test.java renamed to java/ql/test/library-tests/frameworks/android/flow-steps/ParcelTest.java

@@ -19,7 +19,7 @@
 import java.util.Map;
 
 // Test case generated by GenerateFlowTestCase.ql
-public class Test {
+public class ParcelTest {
 
 	Object source() { return null; }
 	void sink(Object o) { }

java/ql/test/library-tests/frameworks/android/flow-steps/WebResourceRequestTest.java

@@ -0,0 +1,35 @@
+package generatedtest;
+
+import android.net.Uri;
+import android.webkit.WebResourceRequest;
+import java.util.Map;
+
+// Test case generated by GenerateFlowTestCase.ql
+public class WebResourceRequestTest {
+
+	Object source() {
+		return null;
+	}
+
+	void sink(Object o) {}
+
+	public void test() throws Exception {
+
+		{
+			// "android.webkit;WebResourceRequest;true;getRequestHeaders;;;Argument[-1];ReturnValue;taint"
+			Map out = null;
+			WebResourceRequest in = (WebResourceRequest) source();
+			out = in.getRequestHeaders();
+			sink(out); // $ hasTaintFlow
+		}
+		{
+			// "android.webkit;WebResourceRequest;true;getUrl;;;Argument[-1];ReturnValue;taint"
+			Uri out = null;
+			WebResourceRequest in = (WebResourceRequest) source();
+			out = in.getUrl();
+			sink(out); // $ hasTaintFlow
+		}
+
+	}
+
+}

java/ql/test/library-tests/frameworks/android/sources/OnActivityResultSourceTest.expected renamed to java/ql/test/library-tests/frameworks/android/sources/AndroidSourcesTest.expected

@@ -4,7 +4,7 @@
 import android.content.Intent;
 import android.os.Bundle;
 
-public class Test extends Activity {
+public class OnActivityResult extends Activity {
 
 	void sink(Object o) {}
 

java/ql/test/library-tests/frameworks/android/sources/OnActivityResultSourceTest.ql renamed to java/ql/test/library-tests/frameworks/android/sources/AndroidSourcesTest.ql

@@ -4,7 +4,7 @@
 import android.os.Bundle;
 import androidx.fragment.app.FragmentTransaction;
 
-public class TestActivityAndFragment extends Activity {
+public class OnActivityResultActivityAndFragment extends Activity {
 
     private TestFragment frag;
 

java/ql/test/library-tests/frameworks/android/sources/Test.java renamed to java/ql/test/library-tests/frameworks/android/sources/OnActivityResult.java

@@ -4,7 +4,7 @@
 import android.content.Intent;
 import android.os.Bundle;
 
-public class TestFragment extends Fragment {
+public class OnActivityResultFragment extends Fragment {
 
     void sink(Object o) {}
 

java/ql/test/library-tests/frameworks/android/sources/TestActivityAndFragment.java renamed to java/ql/test/library-tests/frameworks/android/sources/OnActivityResultActivityAndFragment.java

@@ -5,7 +5,7 @@
 import android.content.Intent;
 import android.os.Bundle;
 
-public class TestMissing extends Activity {
+public class OnActivityResultMissing extends Activity {
 
 	void sink(Object o) {}
 

java/ql/test/library-tests/frameworks/android/sources/TestFragment.java renamed to java/ql/test/library-tests/frameworks/android/sources/OnActivityResultFragment.java

@@ -4,7 +4,7 @@
 import android.content.Intent;
 import android.os.Bundle;
 
-public class Safe extends Activity {
+public class OnActivityResultSafe extends Activity {
 
 	void sink(Object o) {}