Skip to content

Commit 775b53b

Browse files
committed
Fix test to correctly highlight lack of flow from field init
1 parent 20af134 commit 775b53b

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
isFinalField
22
| test.kt:3:3:3:18 | x |
3-
#select
4-
| test.kt:3:3:3:18 | this.x | test.kt:6:10:6:10 | getX(...) |
3+
#select

java/ql/test/kotlin/library-tests/field-initializer-flow/test.ql

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,7 @@ import semmle.code.java.dataflow.DataFlow
44
class Config extends DataFlow::Configuration {
55
Config() { this = "Config" }
66

7-
override predicate isSource(DataFlow::Node n) {
8-
n.asExpr().(CompileTimeConstantExpr).getStringValue() = "Source"
9-
}
7+
override predicate isSource(DataFlow::Node n) { n.asExpr().(StringLiteral).getValue() = "Source" }
108

119
override predicate isSink(DataFlow::Node n) {
1210
n.asExpr().(Argument).getCall().getCallee().getName() = "sink"

0 commit comments

Comments
 (0)