Skip to content

Commit 74e9930

Browse files
hvitvedhvitved
committed
Address review comments
1 parent ac3bfa1 commit 74e9930

29 files changed

+87
-87
lines changed

‎cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,7 @@ private predicate readSet(NodeEx node1, ContentSet c, NodeEx node2, Configuratio
498498
}
499499

500500
// inline to reduce fan-out via `getAReadContent`
501-
pragma[inline]
501+
bindingset[c]
502502
private predicate read(NodeEx node1, Content c, NodeEx node2, Configuration config) {
503503
exists(ContentSet cs |
504504
readSet(node1, cs, node2, config) and
@@ -507,7 +507,7 @@ private predicate read(NodeEx node1, Content c, NodeEx node2, Configuration conf
507507
}
508508

509509
// inline to reduce fan-out via `getAReadContent`
510-
pragma[inline]
510+
bindingset[c]
511511
private predicate clearsContentEx(NodeEx n, Content c) {
512512
exists(ContentSet cs |
513513
clearsContentCached(n.asNode(), cs) and
@@ -516,7 +516,7 @@ private predicate clearsContentEx(NodeEx n, Content c) {
516516
}
517517

518518
// inline to reduce fan-out via `getAReadContent`
519-
pragma[inline]
519+
bindingset[c]
520520
private predicate expectsContentEx(NodeEx n, Content c) {
521521
exists(ContentSet cs |
522522
expectsContentCached(n.asNode(), cs) and

‎cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl2.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,7 @@ private predicate readSet(NodeEx node1, ContentSet c, NodeEx node2, Configuratio
498498
}
499499

500500
// inline to reduce fan-out via `getAReadContent`
501-
pragma[inline]
501+
bindingset[c]
502502
private predicate read(NodeEx node1, Content c, NodeEx node2, Configuration config) {
503503
exists(ContentSet cs |
504504
readSet(node1, cs, node2, config) and
@@ -507,7 +507,7 @@ private predicate read(NodeEx node1, Content c, NodeEx node2, Configuration conf
507507
}
508508

509509
// inline to reduce fan-out via `getAReadContent`
510-
pragma[inline]
510+
bindingset[c]
511511
private predicate clearsContentEx(NodeEx n, Content c) {
512512
exists(ContentSet cs |
513513
clearsContentCached(n.asNode(), cs) and
@@ -516,7 +516,7 @@ private predicate clearsContentEx(NodeEx n, Content c) {
516516
}
517517

518518
// inline to reduce fan-out via `getAReadContent`
519-
pragma[inline]
519+
bindingset[c]
520520
private predicate expectsContentEx(NodeEx n, Content c) {
521521
exists(ContentSet cs |
522522
expectsContentCached(n.asNode(), cs) and

‎cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl3.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,7 @@ private predicate readSet(NodeEx node1, ContentSet c, NodeEx node2, Configuratio
498498
}
499499

500500
// inline to reduce fan-out via `getAReadContent`
501-
pragma[inline]
501+
bindingset[c]
502502
private predicate read(NodeEx node1, Content c, NodeEx node2, Configuration config) {
503503
exists(ContentSet cs |
504504
readSet(node1, cs, node2, config) and
@@ -507,7 +507,7 @@ private predicate read(NodeEx node1, Content c, NodeEx node2, Configuration conf
507507
}
508508

509509
// inline to reduce fan-out via `getAReadContent`
510-
pragma[inline]
510+
bindingset[c]
511511
private predicate clearsContentEx(NodeEx n, Content c) {
512512
exists(ContentSet cs |
513513
clearsContentCached(n.asNode(), cs) and
@@ -516,7 +516,7 @@ private predicate clearsContentEx(NodeEx n, Content c) {
516516
}
517517

518518
// inline to reduce fan-out via `getAReadContent`
519-
pragma[inline]
519+
bindingset[c]
520520
private predicate expectsContentEx(NodeEx n, Content c) {
521521
exists(ContentSet cs |
522522
expectsContentCached(n.asNode(), cs) and

‎cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl4.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,7 @@ private predicate readSet(NodeEx node1, ContentSet c, NodeEx node2, Configuratio
498498
}
499499

500500
// inline to reduce fan-out via `getAReadContent`
501-
pragma[inline]
501+
bindingset[c]
502502
private predicate read(NodeEx node1, Content c, NodeEx node2, Configuration config) {
503503
exists(ContentSet cs |
504504
readSet(node1, cs, node2, config) and
@@ -507,7 +507,7 @@ private predicate read(NodeEx node1, Content c, NodeEx node2, Configuration conf
507507
}
508508

509509
// inline to reduce fan-out via `getAReadContent`
510-
pragma[inline]
510+
bindingset[c]
511511
private predicate clearsContentEx(NodeEx n, Content c) {
512512
exists(ContentSet cs |
513513
clearsContentCached(n.asNode(), cs) and
@@ -516,7 +516,7 @@ private predicate clearsContentEx(NodeEx n, Content c) {
516516
}
517517

518518
// inline to reduce fan-out via `getAReadContent`
519-
pragma[inline]
519+
bindingset[c]
520520
private predicate expectsContentEx(NodeEx n, Content c) {
521521
exists(ContentSet cs |
522522
expectsContentCached(n.asNode(), cs) and

‎cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImplLocal.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,7 @@ private predicate readSet(NodeEx node1, ContentSet c, NodeEx node2, Configuratio
498498
}
499499

500500
// inline to reduce fan-out via `getAReadContent`
501-
pragma[inline]
501+
bindingset[c]
502502
private predicate read(NodeEx node1, Content c, NodeEx node2, Configuration config) {
503503
exists(ContentSet cs |
504504
readSet(node1, cs, node2, config) and
@@ -507,7 +507,7 @@ private predicate read(NodeEx node1, Content c, NodeEx node2, Configuration conf
507507
}
508508

509509
// inline to reduce fan-out via `getAReadContent`
510-
pragma[inline]
510+
bindingset[c]
511511
private predicate clearsContentEx(NodeEx n, Content c) {
512512
exists(ContentSet cs |
513513
clearsContentCached(n.asNode(), cs) and
@@ -516,7 +516,7 @@ private predicate clearsContentEx(NodeEx n, Content c) {
516516
}
517517

518518
// inline to reduce fan-out via `getAReadContent`
519-
pragma[inline]
519+
bindingset[c]
520520
private predicate expectsContentEx(NodeEx n, Content c) {
521521
exists(ContentSet cs |
522522
expectsContentCached(n.asNode(), cs) and

‎cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,7 @@ private predicate readSet(NodeEx node1, ContentSet c, NodeEx node2, Configuratio
498498
}
499499

500500
// inline to reduce fan-out via `getAReadContent`
501-
pragma[inline]
501+
bindingset[c]
502502
private predicate read(NodeEx node1, Content c, NodeEx node2, Configuration config) {
503503
exists(ContentSet cs |
504504
readSet(node1, cs, node2, config) and
@@ -507,7 +507,7 @@ private predicate read(NodeEx node1, Content c, NodeEx node2, Configuration conf
507507
}
508508

509509
// inline to reduce fan-out via `getAReadContent`
510-
pragma[inline]
510+
bindingset[c]
511511
private predicate clearsContentEx(NodeEx n, Content c) {
512512
exists(ContentSet cs |
513513
clearsContentCached(n.asNode(), cs) and
@@ -516,7 +516,7 @@ private predicate clearsContentEx(NodeEx n, Content c) {
516516
}
517517

518518
// inline to reduce fan-out via `getAReadContent`
519-
pragma[inline]
519+
bindingset[c]
520520
private predicate expectsContentEx(NodeEx n, Content c) {
521521
exists(ContentSet cs |
522522
expectsContentCached(n.asNode(), cs) and

‎cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl2.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,7 @@ private predicate readSet(NodeEx node1, ContentSet c, NodeEx node2, Configuratio
498498
}
499499

500500
// inline to reduce fan-out via `getAReadContent`
501-
pragma[inline]
501+
bindingset[c]
502502
private predicate read(NodeEx node1, Content c, NodeEx node2, Configuration config) {
503503
exists(ContentSet cs |
504504
readSet(node1, cs, node2, config) and
@@ -507,7 +507,7 @@ private predicate read(NodeEx node1, Content c, NodeEx node2, Configuration conf
507507
}
508508

509509
// inline to reduce fan-out via `getAReadContent`
510-
pragma[inline]
510+
bindingset[c]
511511
private predicate clearsContentEx(NodeEx n, Content c) {
512512
exists(ContentSet cs |
513513
clearsContentCached(n.asNode(), cs) and
@@ -516,7 +516,7 @@ private predicate clearsContentEx(NodeEx n, Content c) {
516516
}
517517

518518
// inline to reduce fan-out via `getAReadContent`
519-
pragma[inline]
519+
bindingset[c]
520520
private predicate expectsContentEx(NodeEx n, Content c) {
521521
exists(ContentSet cs |
522522
expectsContentCached(n.asNode(), cs) and

‎cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl3.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,7 @@ private predicate readSet(NodeEx node1, ContentSet c, NodeEx node2, Configuratio
498498
}
499499

500500
// inline to reduce fan-out via `getAReadContent`
501-
pragma[inline]
501+
bindingset[c]
502502
private predicate read(NodeEx node1, Content c, NodeEx node2, Configuration config) {
503503
exists(ContentSet cs |
504504
readSet(node1, cs, node2, config) and
@@ -507,7 +507,7 @@ private predicate read(NodeEx node1, Content c, NodeEx node2, Configuration conf
507507
}
508508

509509
// inline to reduce fan-out via `getAReadContent`
510-
pragma[inline]
510+
bindingset[c]
511511
private predicate clearsContentEx(NodeEx n, Content c) {
512512
exists(ContentSet cs |
513513
clearsContentCached(n.asNode(), cs) and
@@ -516,7 +516,7 @@ private predicate clearsContentEx(NodeEx n, Content c) {
516516
}
517517

518518
// inline to reduce fan-out via `getAReadContent`
519-
pragma[inline]
519+
bindingset[c]
520520
private predicate expectsContentEx(NodeEx n, Content c) {
521521
exists(ContentSet cs |
522522
expectsContentCached(n.asNode(), cs) and

‎cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl4.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,7 @@ private predicate readSet(NodeEx node1, ContentSet c, NodeEx node2, Configuratio
498498
}
499499

500500
// inline to reduce fan-out via `getAReadContent`
501-
pragma[inline]
501+
bindingset[c]
502502
private predicate read(NodeEx node1, Content c, NodeEx node2, Configuration config) {
503503
exists(ContentSet cs |
504504
readSet(node1, cs, node2, config) and
@@ -507,7 +507,7 @@ private predicate read(NodeEx node1, Content c, NodeEx node2, Configuration conf
507507
}
508508

509509
// inline to reduce fan-out via `getAReadContent`
510-
pragma[inline]
510+
bindingset[c]
511511
private predicate clearsContentEx(NodeEx n, Content c) {
512512
exists(ContentSet cs |
513513
clearsContentCached(n.asNode(), cs) and
@@ -516,7 +516,7 @@ private predicate clearsContentEx(NodeEx n, Content c) {
516516
}
517517

518518
// inline to reduce fan-out via `getAReadContent`
519-
pragma[inline]
519+
bindingset[c]
520520
private predicate expectsContentEx(NodeEx n, Content c) {
521521
exists(ContentSet cs |
522522
expectsContentCached(n.asNode(), cs) and

‎csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,7 @@ private predicate readSet(NodeEx node1, ContentSet c, NodeEx node2, Configuratio
498498
}
499499

500500
// inline to reduce fan-out via `getAReadContent`
501-
pragma[inline]
501+
bindingset[c]
502502
private predicate read(NodeEx node1, Content c, NodeEx node2, Configuration config) {
503503
exists(ContentSet cs |
504504
readSet(node1, cs, node2, config) and
@@ -507,7 +507,7 @@ private predicate read(NodeEx node1, Content c, NodeEx node2, Configuration conf
507507
}
508508

509509
// inline to reduce fan-out via `getAReadContent`
510-
pragma[inline]
510+
bindingset[c]
511511
private predicate clearsContentEx(NodeEx n, Content c) {
512512
exists(ContentSet cs |
513513
clearsContentCached(n.asNode(), cs) and
@@ -516,7 +516,7 @@ private predicate clearsContentEx(NodeEx n, Content c) {
516516
}
517517

518518
// inline to reduce fan-out via `getAReadContent`
519-
pragma[inline]
519+
bindingset[c]
520520
private predicate expectsContentEx(NodeEx n, Content c) {
521521
exists(ContentSet cs |
522522
expectsContentCached(n.asNode(), cs) and

0 commit comments

Comments
 (0)