simplify int check

erik-krogh · asgerf · erik-krogh · commit 74a79f862291 · 2022-09-05T16:11:55.000+02:00
Co-authored-by: Asger F &lt;asgerf@github.com&gt;
diff --git a/javascript/ql/lib/semmle/javascript/security/dataflow/ClientSideUrlRedirectCustomizations.qll b/javascript/ql/lib/semmle/javascript/security/dataflow/ClientSideUrlRedirectCustomizations.qll
@@ -67,7 +67,7 @@ module ClientSideUrlRedirect {
       methodName = StringOps::substringMethodName() and
       // exclude `location.href.substring(0, ...)` and similar, which can
       // never refer to the query string
-      not mcn.getArgument(0).asExpr().(NumberLiteral).getIntValue() = 0
+      not mcn.getArgument(0).getIntValue() = 0
     )
     or
     exists(DataFlow::MethodCallNode mcn |

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ module ClientSideUrlRedirect {`
`67`	`67`	`methodName = StringOps::substringMethodName() and`
`68`	`68`	// exclude `location.href.substring(0, ...)` and similar, which can
`69`	`69`	`// never refer to the query string`
`70`		`- not mcn.getArgument(0).asExpr().(NumberLiteral).getIntValue() = 0`
	`70`	`+ not mcn.getArgument(0).getIntValue() = 0`
`71`	`71`	`)`
`72`	`72`	`or`
`73`	`73`	`exists(DataFlow::MethodCallNode mcn \|`