Simplify test for no-arg constructor

smowton · web-flow · commit 74641ccfee54 · 2022-07-11T11:01:19.000+01:00
diff --git a/java/ql/src/experimental/Security/CWE/CWE-327/Azure/UnsafeUsageOfClientSideEncryptionVersion.ql b/java/ql/src/experimental/Security/CWE/CWE-327/Azure/UnsafeUsageOfClientSideEncryptionVersion.ql
@@ -24,7 +24,7 @@ predicate isCreatingOutdatedAzureClientSideEncryptionObject(Call call, Class c)
     (
       type = "EncryptedBlobClientBuilder" and
       package = "com.azure.storage.blob.specialized.cryptography" and
-      not exists(Expr e | e = call.getArgument(0))
+      constructor.hasNoParameters()
       or
       type = "BlobEncryptionPolicy" and package = "com.microsoft.azure.storage.blob"
     )

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ predicate isCreatingOutdatedAzureClientSideEncryptionObject(Call call, Class c)`
`24`	`24`	`(`
`25`	`25`	`type = "EncryptedBlobClientBuilder" and`
`26`	`26`	`package = "com.azure.storage.blob.specialized.cryptography" and`
`27`		`- not exists(Expr e \| e = call.getArgument(0))`
	`27`	`+ constructor.hasNoParameters()`
`28`	`28`	`or`
`29`	`29`	`type = "BlobEncryptionPolicy" and package = "com.microsoft.azure.storage.blob"`
`30`	`30`	`)`