C#: Generic classes should not be considered controllers.

michaelnebel · michaelnebel · commit 72429cb9e89c · 2022-09-26T14:55:28.000+02:00
diff --git a/csharp/ql/lib/semmle/code/csharp/frameworks/microsoft/AspNetCore.qll b/csharp/ql/lib/semmle/code/csharp/frameworks/microsoft/AspNetCore.qll
@@ -205,7 +205,7 @@ class MicrosoftAspNetCoreMvcController extends Class {
     ) and
     this.isPublic() and
     not this.isAbstract() and
-    not this.containsTypeParameters() and
+    not this instanceof Generic and
     (
       this.getABaseType*() instanceof MicrosoftAspNetCoreMvcControllerBaseClass
       or

Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,7 @@ class MicrosoftAspNetCoreMvcController extends Class {`
`205`	`205`	`) and`
`206`	`206`	`this.isPublic() and`
`207`	`207`	`not this.isAbstract() and`
`208`		`- not this.containsTypeParameters() and`
	`208`	`+ not this instanceof Generic and`
`209`	`209`	`(`
`210`	`210`	`this.getABaseType*() instanceof MicrosoftAspNetCoreMvcControllerBaseClass`
`211`	`211`	`or`