Skip to content

Commit 6e630cc

Browse files
asgerferik-krogh
andauthored
Apply suggestions from code review
Co-authored-by: Erik Krogh Kristensen <erik-krogh@github.com>
1 parent cf596a1 commit 6e630cc

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

javascript/ql/lib/semmle/javascript/ApiGraphs.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -794,7 +794,7 @@ module API {
794794
}
795795

796796
/**
797-
* Holds if `ref` is both a use and def-node that should an incoming edge from `base` labelled `lbl`.
797+
* Holds if `ref` corresponds to both a use and def-node that should have an incoming edge from `base` labelled `lbl`.
798798
*
799799
* This happens because the decorated value escapes into the decorator function, and is then replaced
800800
* by the function's return value. In the JS analysis we generally assume decorators return their input,
@@ -847,8 +847,8 @@ module API {
847847
* Since fields do not have their own data-flow nodes, we generate a node for each read or write.
848848
* For property writes, the right-hand side becomes a def-node and property reads become use-nodes.
849849
*
850-
* For accessors, we generate nodes both internally in the accessor, and for each use of the accessor. This
851-
* predicate only gets the uses.
850+
* For accessors this predicate computes each use of the accessor.
851+
* The return value inside the accessor is computed by the `decoratorRhsEdge` predicate.
852852
*/
853853
private predicate decoratorPropEdge(TApiNode base, Label::ApiLabel lbl, DataFlow::PropRef ref) {
854854
exists(MemberDefinition fieldLike, DataFlow::ClassNode cls |

0 commit comments

Comments
 (0)