Skip to content

Commit 6d3f87f

Browse files
committed
Ruby: Small fixes
1 parent bc1723c commit 6d3f87f

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

ruby/ql/lib/codeql/ruby/frameworks/ActiveStorage.qll

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ module ActiveStorage {
8787
// Class methods
8888
API::getTopLevelMember("ActiveStorage")
8989
.getMember("Blob")
90-
.getASubclass*()
90+
.getASubclass()
9191
.getAMethodCall(["create_after_unfurling!", "create_and_upload!"]),
9292
// Instance methods
9393
any(BlobInstance i, DataFlow::CallNode c |
@@ -153,11 +153,7 @@ module ActiveStorage {
153153
|
154154
call = this and
155155
call.getReceiver().(ActiveRecordInstance).getClass() = assoc.getSourceClass() and
156-
(
157-
assoc.isSingular() and call.getMethodName() = model
158-
or
159-
assoc.isCollection() and call.getMethodName() = model
160-
)
156+
call.getMethodName() = model
161157
)
162158
or
163159
any(AttachmentInstance i).(DataFlow::LocalSourceNode).flowsTo(this)

0 commit comments

Comments
 (0)