Skip to content

Commit 6cacf7b

Browse files
committed
Ruby: isLocalSourceNode needs SynthReturnNode
1 parent 89c4b6c commit 6cacf7b

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowPrivate.qll

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -302,6 +302,11 @@ private module Cached {
302302
or
303303
n instanceof PostUpdateNodes::ExprPostUpdateNode
304304
or
305+
// TODO: Explain why SynthReturnNode is needed!
306+
// if we don't include this, we are not able to find this call:
307+
// https://github.com/github/codeql/blob/976daddd36a63bf46836d141d04172e90bb4b33c/ruby/ql/test/library-tests/frameworks/http_clients/NetHttp.rb#L24
308+
n instanceof SynthReturnNode
309+
or
305310
// Expressions that can't be reached from another entry definition or expression.
306311
n instanceof ExprNode and
307312
not localFlowStepTypeTracker+(any(Node n0 |

0 commit comments

Comments
 (0)