C++: Fix block assignment evaluation order comment in IR translation

jketema · jketema · commit 6c4685e53829 · 2022-08-15T11:58:57.000+02:00
diff --git a/cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedExpr.qll b/cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedExpr.qll
@@ -1501,7 +1501,7 @@ class TranslatedBlockAssignExpr extends TranslatedNonConstantExpr {
   }
 
   final override Instruction getFirstInstruction() {
-    // The operand evaluation order should since block assignments behave like memcpy.
+    // The operand evaluation order should not matter since block assignments behave like memcpy.
     result = this.getLeftOperand().getFirstInstruction()
   }
 

Original file line number	Diff line number	Diff line change
`@@ -1501,7 +1501,7 @@ class TranslatedBlockAssignExpr extends TranslatedNonConstantExpr {`
`1501`	`1501`	`}`
`1502`	`1502`
`1503`	`1503`	`final override Instruction getFirstInstruction() {`
`1504`		`- // The operand evaluation order should since block assignments behave like memcpy.`
	`1504`	`+ // The operand evaluation order should not matter since block assignments behave like memcpy.`
`1505`	`1505`	`result = this.getLeftOperand().getFirstInstruction()`
`1506`	`1506`	`}`
`1507`	`1507`