Skip to content

Commit 6799838

Browse files
committed
Simplification
1 parent 833d842 commit 6799838

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

java/ql/src/experimental/Security/CWE/CWE-200/AndroidWebResourceResponse.qll

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -55,15 +55,13 @@ private class FetchUrlStep extends AdditionalValueStep {
5555
override predicate step(DataFlow::Node pred, DataFlow::Node succ) {
5656
exists(
5757
// webview.loadUrl(url) -> webview.setWebViewClient(new WebViewClient() { shouldInterceptRequest(view, url) });
58-
WebViewLoadUrlMethod lm, ShouldInterceptRequestMethod im, SetWebViewClientMethodAccess sma
58+
MethodAccess lma, ShouldInterceptRequestMethod im, SetWebViewClientMethodAccess sma
5959
|
6060
sma.getArgument(0).getType() = im.getDeclaringType().getASupertype*() and
61-
exists(MethodAccess lma |
62-
lma.getMethod() = lm and
63-
lma.getQualifier().getType() = sma.getQualifier().getType() and
64-
pred.asExpr() = lma.getArgument(0) and
65-
succ.asParameter() = im.getParameter(1)
66-
)
61+
lma.getMethod() instanceof WebViewLoadUrlMethod and
62+
lma.getQualifier().getType() = sma.getQualifier().getType() and
63+
pred.asExpr() = lma.getArgument(0) and
64+
succ.asParameter() = im.getParameter(1)
6765
)
6866
}
6967
}

0 commit comments

Comments
 (0)