Skip to content

Commit 65f3ae9

Browse files
Jami CogswellJami Cogswell
authored andcommitted
clean up files
1 parent 7e13610 commit 65f3ae9

File tree

6 files changed

+117
-201
lines changed

6 files changed

+117
-201
lines changed

java/ql/lib/semmle/code/java/frameworks/android/Intent.qll

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -70,11 +70,7 @@ class AndroidReceiveIntentMethod extends Method {
7070
*/
7171
class AndroidServiceIntentMethod extends Method {
7272
AndroidServiceIntentMethod() {
73-
(
74-
this.getName().matches("onStart%") or
75-
this.getName().matches("on%ind") or
76-
this.hasName("onTaskRemoved")
77-
) and
73+
this.getName().matches(["onStart%", "on%ind", "onTaskRemoved"]) and
7874
this.getDeclaringType() instanceof TypeService
7975
}
8076
}

java/ql/test/library-tests/dataflow/taintsources/IntentSourcesActivity.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@
44

55
public class IntentSourcesActivity extends Activity {
66

7-
private static void sink(Object o) {
8-
}
7+
private static void sink(Object o) {}
98

109
public void test() throws java.io.IOException {
1110

@@ -31,8 +30,7 @@ public void test3() throws java.io.IOException {
3130

3231
class OtherClass {
3332

34-
private static void sink(Object o) {
35-
}
33+
private static void sink(Object o) {}
3634

3735
public void test(IntentSourcesActivity is) throws java.io.IOException {
3836
String trouble = is.getIntent().getStringExtra("key");

java/ql/test/library-tests/dataflow/taintsources/IntentSourcesReceiver.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@
66

77
public class IntentSourcesReceiver extends BroadcastReceiver {
88

9-
private static void sink(Object o) {
10-
}
9+
private static void sink(Object o) {}
1110

1211
@Override
1312
public void onReceive(Context context, Intent intent) {

java/ql/test/library-tests/dataflow/taintsources/IntentSourcesService.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77

88
public class IntentSourcesService extends Service {
99

10-
private static void sink(Object o) {
11-
}
10+
private static void sink(Object o) {}
1211

1312
@Override
1413
public void onStart(Intent intent, int startId) {

0 commit comments

Comments
 (0)