C++: Add a sanitizer to 'cpp/cleartext-storage-buffer' to improve the performance of the query.

MathiasVP · MathiasVP · commit 65abb54a7368 · 2022-08-22T11:01:31.000+01:00
diff --git a/cpp/ql/src/Security/CWE/CWE-311/CleartextBufferWrite.ql b/cpp/ql/src/Security/CWE/CWE-311/CleartextBufferWrite.ql
@@ -26,6 +26,10 @@ class ToBufferConfiguration extends TaintTracking::Configuration {
 
   override predicate isSource(DataFlow::Node source) { source instanceof FlowSource }
 
+  override predicate isSanitizer(DataFlow::Node node) {
+    node.asExpr().getUnspecifiedType() instanceof IntegralType
+  }
+
   override predicate isSink(DataFlow::Node sink) {
     exists(BufferWrite::BufferWrite w | w.getASource() = sink.asExpr())
   }

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,10 @@ class ToBufferConfiguration extends TaintTracking::Configuration {`
`26`	`26`
`27`	`27`	`override predicate isSource(DataFlow::Node source) { source instanceof FlowSource }`
`28`	`28`
	`29`	`+ override predicate isSanitizer(DataFlow::Node node) {`
	`30`	`+ node.asExpr().getUnspecifiedType() instanceof IntegralType`
	`31`	`+ }`
	`32`	`+`
`29`	`33`	`override predicate isSink(DataFlow::Node sink) {`
`30`	`34`	`exists(BufferWrite::BufferWrite w \| w.getASource() = sink.asExpr())`
`31`	`35`	`}`