Skip to content

Commit 62f2614

Browse files
committed
move hasDominatingWrite to the TypeTracking stage
1 parent 1db6a64 commit 62f2614

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

javascript/ql/lib/semmle/javascript/GlobalAccessPaths.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -557,7 +557,7 @@ module AccessPath {
557557
*/
558558
cached
559559
predicate hasDominatingWrite(DataFlow::PropRead read) {
560-
Stages::FlowSteps::ref() and
560+
Stages::TypeTracking::ref() and
561561
// within the same basic block.
562562
exists(ReachableBasicBlock bb, Root root, string path, int ranking |
563563
read.asExpr() = rankedAccessPath(bb, root, path, ranking, AccessPathRead()) and

javascript/ql/lib/semmle/javascript/internal/CachedStages.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -212,6 +212,8 @@ module Stages {
212212
any(DataFlow::Node node).hasUnderlyingType(_)
213213
or
214214
any(DataFlow::Node node).hasUnderlyingType(_, _)
215+
or
216+
AccessPath::DominatingPaths::hasDominatingWrite(_)
215217
}
216218
}
217219

@@ -235,8 +237,6 @@ module Stages {
235237
predicate backref() {
236238
1 = 1
237239
or
238-
AccessPath::DominatingPaths::hasDominatingWrite(_)
239-
or
240240
DataFlow::SharedFlowStep::step(_, _)
241241
}
242242
}

0 commit comments

Comments
 (0)