Skip to content

Commit 5dfa5fb

Browse files
authored
Merge pull request #9678 from jketema/ql-fixes
C++: Two small QL fixes
2 parents 08e4c8b + b3ac7bd commit 5dfa5fb

File tree

2 files changed

+8
-14
lines changed

2 files changed

+8
-14
lines changed

cpp/ql/lib/semmle/code/cpp/internal/QualifiedName.qll

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,7 @@
44
* qualified.
55
*
66
* This file contains classes that mirror the standard AST classes for C++, but
7-
* these classes are only concerned with naming. The other difference is that
8-
* these classes don't use the `ResolveClass.qll` mechanisms like
9-
* `unresolveElement` because these classes should eventually be part of the
10-
* implementation of `ResolveClass.qll`, allowing it to match up classes when
11-
* their qualified names and parameters match.
7+
* these classes are only concerned with naming.
128
*/
139

1410
private import semmle.code.cpp.Declaration as D

cpp/ql/lib/semmle/code/cpp/internal/ResolveClass.qll

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -115,15 +115,13 @@ private module Cached {
115115
*/
116116
cached
117117
predicate isClass(@usertype t) {
118-
(
119-
usertypes(t, _, 1) or
120-
usertypes(t, _, 2) or
121-
usertypes(t, _, 3) or
122-
usertypes(t, _, 6) or
123-
usertypes(t, _, 10) or
124-
usertypes(t, _, 11) or
125-
usertypes(t, _, 12)
126-
)
118+
usertypes(t, _, 1) or
119+
usertypes(t, _, 2) or
120+
usertypes(t, _, 3) or
121+
usertypes(t, _, 6) or
122+
usertypes(t, _, 10) or
123+
usertypes(t, _, 11) or
124+
usertypes(t, _, 12)
127125
}
128126

129127
cached

0 commit comments

Comments
 (0)