Python: Add test to ensure we keep DataFlow imports clean

RasmusWL · RasmusWL · commit 5dbbd17bb27d · 2022-04-20T11:41:01.000+02:00
Currently we're not in a good state :(
diff --git a/python/ql/test/experimental/dataflow/qll-private-imports/README.md b/python/ql/test/experimental/dataflow/qll-private-imports/README.md
@@ -0,0 +1,3 @@
+Sometimes we accidentally re-export too much from `DataFlow` such that for example we can access `Add` from `DataFlow::Add` :disappointed:
+
+This test should always FAIL to compile!
diff --git a/python/ql/test/experimental/dataflow/qll-private-imports/Test.expected b/python/ql/test/experimental/dataflow/qll-private-imports/Test.expected
@@ -0,0 +1 @@
+| Add |
diff --git a/python/ql/test/experimental/dataflow/qll-private-imports/Test.ql b/python/ql/test/experimental/dataflow/qll-private-imports/Test.ql
@@ -0,0 +1,8 @@
+import python
+private import semmle.python.dataflow.new.DataFlow
+
+// Sometimes we accidentally re-export too much from `DataFlow` such that for example we can access `Add` from `DataFlow::Add` :(
+//
+// This test should always FAIL to compile!
+from DataFlow::Add this_should_not_work
+select this_should_not_work
diff --git a/python/ql/test/experimental/dataflow/qll-private-imports/test.py b/python/ql/test/experimental/dataflow/qll-private-imports/test.py
@@ -0,0 +1 @@
+1+1

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	+Sometimes we accidentally re-export too much from `DataFlow` such that for example we can access `Add` from `DataFlow::Add` :disappointed:
	`2`	`+`
	`3`	`+This test should always FAIL to compile!`