Skip to content

Commit 59c1ac2

Browse files
erik-kroghesbena
andauthored
Apply suggestions from code review
Co-authored-by: Esben Sparre Andreasen <esbena@github.com>
1 parent 93a6710 commit 59c1ac2

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

ql/ql/src/queries/style/AlertMessage.ql

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
/**
2-
* @name Alert messages style violation
3-
* @description Alert message that doesn't follow some aspect of the style guide.
2+
* @name Alert message style violation
3+
* @description An alert message that doesn't follow the style guide is harder for end users to digest.
44
* See the style guide here: https://github.com/github/codeql/blob/main/docs/query-metadata-style-guide.md#alert-messages
55
* @kind problem
66
* @problem.severity warning
7-
* @id ql/alert-messages-style-violation
7+
* @id ql/alert-message-style-violation
88
* @precision high
99
*/
1010

@@ -132,9 +132,9 @@ where
132132
msg = "Don't quote substitutions in alert messages."
133133
or
134134
node = wrongFlowsPhrase(_, "data") and
135-
msg = "Use \"flows to\" instead of \"depends on\" in taint tracking queries."
135+
msg = "Use \"flows to\" instead of \"depends on\" in data flow queries."
136136
or
137137
node = wrongFlowsPhrase(_, "taint") and
138-
msg = "Use \"depends on\" instead of \"flows to\" in data flow queries."
138+
msg = "Use \"depends on\" instead of \"flows to\" in taint tracking queries."
139139
)
140140
select node, msg

0 commit comments

Comments
 (0)