QL: remove some benign results from ql/abstract-class-import

erik-krogh · erik-krogh · commit 58fcdbc4061e · 2022-04-20T18:17:08.000+02:00
diff --git a/ql/ql/src/queries/performance/AbstractClassImport.ql b/ql/ql/src/queries/performance/AbstractClassImport.ql
@@ -97,7 +97,11 @@ predicate alert(Class ab, string msg, Class sub, Class sub2) {
     )
   ) and
   // exclude results in experimental
-  not experimentalFile(sub.getLocation().getFile())
+  not experimentalFile(sub.getLocation().getFile()) and
+  // exclude trivially empty classes
+  not sub.getCharPred().getBody() instanceof NoneCall and
+  // exclude test/example queries
+  not sub.getLocation().getFile().getRelativePath().matches("%/" + ["examples", "test"] + "/%.ql")
 }
 
 from Class ab, string msg, Class sub, Class sub2

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,11 @@ predicate alert(Class ab, string msg, Class sub, Class sub2) {`
`97`	`97`	`)`
`98`	`98`	`) and`
`99`	`99`	`// exclude results in experimental`
`100`		`- not experimentalFile(sub.getLocation().getFile())`
	`100`	`+ not experimentalFile(sub.getLocation().getFile()) and`
	`101`	`+ // exclude trivially empty classes`
	`102`	`+ not sub.getCharPred().getBody() instanceof NoneCall and`
	`103`	`+ // exclude test/example queries`
	`104`	`+ not sub.getLocation().getFile().getRelativePath().matches("%/" + ["examples", "test"] + "/%.ql")`
`101`	`105`	`}`
`102`	`106`
`103`	`107`	`from Class ab, string msg, Class sub, Class sub2`