Skip to content

Commit 49259a6

Browse files
committed
Remove everything related to WebView CSV models
This reverts commit c6c72eb.
1 parent dce11f3 commit 49259a6

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

59 files changed

+1971
-1785
lines changed

java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ private module Frameworks {
8686
private import semmle.code.java.frameworks.android.Slice
8787
private import semmle.code.java.frameworks.android.SQLite
8888
private import semmle.code.java.frameworks.android.Widget
89-
private import semmle.code.java.frameworks.android.WebView
9089
private import semmle.code.java.frameworks.android.XssSinks
9190
private import semmle.code.java.frameworks.ApacheHttp
9291
private import semmle.code.java.frameworks.apache.Collections

java/ql/lib/semmle/code/java/frameworks/android/WebView.qll

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import java
2-
private import semmle.code.java.dataflow.ExternalFlow
32

43
/** The class `android.webkit.WebView`. */
54
class TypeWebView extends Class {
@@ -75,32 +74,3 @@ class ShouldOverrideUrlLoading extends Method {
7574
this.hasName("shouldOverrideUrlLoading")
7675
}
7776
}
78-
79-
private class WebkitSourceModels extends SourceModelCsv {
80-
override predicate row(string row) {
81-
row =
82-
[
83-
"android.webkit;WebViewClient;true;doUpdateVisitedHistory;;;Parameter[1];remote",
84-
"android.webkit;WebViewClient;true;onLoadResource;;;Parameter[1];remote",
85-
"android.webkit;WebViewClient;true;onPageCommitVisible;;;Parameter[1];remote",
86-
"android.webkit;WebViewClient;true;onPageFinished;;;Parameter[1];remote",
87-
"android.webkit;WebViewClient;true;onPageStarted;;;Parameter[1];remote",
88-
"android.webkit;WebViewClient;true;onReceivedError;(WebView,int,String,String);;Parameter[3];remote",
89-
"android.webkit;WebViewClient;true;onReceivedError;(WebView,WebResourceRequest,WebResourceError);;Parameter[1];remote",
90-
"android.webkit;WebViewClient;true;onReceivedHttpError;;;Parameter[1];remote",
91-
"android.webkit;WebViewClient;true;onSafeBrowsingHit;;;Parameter[1];remote",
92-
"android.webkit;WebViewClient;true;shouldInterceptRequest;;;Parameter[1];remote",
93-
"android.webkit;WebViewClient;true;shouldOverrideUrlLoading;;;Parameter[1];remote"
94-
]
95-
}
96-
}
97-
98-
private class WebkitSummaryModels extends SummaryModelCsv {
99-
override predicate row(string row) {
100-
row =
101-
[
102-
"android.webkit;WebResourceRequest;true;getRequestHeaders;;;Argument[-1];ReturnValue;taint",
103-
"android.webkit;WebResourceRequest;true;getUrl;;;Argument[-1];ReturnValue;taint"
104-
]
105-
}
106-
}

java/ql/test/library-tests/frameworks/android/flow-steps/ParcelTest.java renamed to java/ql/test/library-tests/frameworks/android/flow-steps/Test.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import java.util.Map;
2020

2121
// Test case generated by GenerateFlowTestCase.ql
22-
public class ParcelTest {
22+
public class Test {
2323

2424
Object source() { return null; }
2525
void sink(Object o) { }

java/ql/test/library-tests/frameworks/android/flow-steps/WebResourceRequestTest.java

Lines changed: 0 additions & 35 deletions
This file was deleted.

java/ql/test/library-tests/frameworks/android/sources/OnActivityResultSafe.java renamed to java/ql/test/library-tests/frameworks/android/sources/Safe.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import android.content.Intent;
55
import android.os.Bundle;
66

7-
public class OnActivityResultSafe extends Activity {
7+
public class Safe extends Activity {
88

99
void sink(Object o) {}
1010

java/ql/test/library-tests/frameworks/android/sources/OnActivityResultSafe2.java renamed to java/ql/test/library-tests/frameworks/android/sources/Safe2.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import android.content.Intent;
55
import android.os.Bundle;
66

7-
public class OnActivityResultSafe2 extends Activity {
7+
public class Safe2 extends Activity {
88

99
void sink(Object o) {}
1010

java/ql/test/library-tests/frameworks/android/sources/OnActivityResult.java renamed to java/ql/test/library-tests/frameworks/android/sources/Test.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import android.content.Intent;
55
import android.os.Bundle;
66

7-
public class OnActivityResult extends Activity {
7+
public class Test extends Activity {
88

99
void sink(Object o) {}
1010

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import android.os.Bundle;
55
import androidx.fragment.app.FragmentTransaction;
66

7-
public class OnActivityResultActivityAndFragment extends Activity {
7+
public class TestActivityAndFragment extends Activity {
88

99
private TestFragment frag;
1010

0 commit comments

Comments
 (0)