Skip to content

Commit 475d67a

Browse files
Jami CogswellJami Cogswell
authored andcommitted
minor updates, removed comments
1 parent e2374f8 commit 475d67a

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

java/ql/src/Security/CWE/CWE-489/DebuggableAttributeTrue.ql

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,5 @@ from AndroidXmlAttribute androidXmlAttr
1717
where
1818
androidXmlAttr.getName() = "debuggable" and
1919
androidXmlAttr.getValue() = "true" and
20-
not androidXmlAttr.getLocation().getFile().getAbsolutePath().matches("%/build%") // USE THIS (from speaking with Tony) - 11 MRVA results
21-
//not androidXmlAttr.getLocation().toString().matches("%build%") // my original query - 2 MRVA results
22-
//not androidXmlAttr.getLocation().toString().matches("%/build%") // 11 MRVA results
23-
//not androidXmlAttr.getLocation().getFile().getAbsolutePath().matches("%build%") // 2 MRVA results...
24-
// comment for test commit to new branch
25-
select androidXmlAttr, "The 'debuggable' attribute is enabled."
20+
not androidXmlAttr.getLocation().getFile().getRelativePath().matches("%/build%")
21+
select androidXmlAttr, "The 'android:debuggable' attribute is enabled."

java/ql/src/Security/CWE/CWE-489/DebuggableFalse.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<manifest ... >
2-
<!-- GOOD: 'android:debuggable' set to false -->
2+
<!-- GOOD: 'android:debuggable' set to 'false' -->
33
<application
44
android:debuggable="false">
55
<activity ... >

java/ql/src/Security/CWE/CWE-489/DebuggableTrue.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<manifest ... >
2-
<!-- BAD: 'android:debuggable' set to true -->
2+
<!-- BAD: 'android:debuggable' set to 'true' -->
33
<application
44
android:debuggable="true">
55
<activity ... >

0 commit comments

Comments
 (0)