Skip to content

Commit 44bd038

Browse files
Apply docs suggestions from code review
Co-authored-by: Ben Ahmady <32935794+subatoi@users.noreply.github.com>
1 parent a6a500a commit 44bd038

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

java/ql/src/Security/CWE/CWE-489/WebviewDebuggingEnabled.qhelp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@
66
<overview>
77
<p>The <code>WebView.setWebContentsDebuggingEnabled</code> method enables or disables the contents of any <code>WebView</code> in the application to be debugged.</p>
88

9-
<p>Enabling debugging features could allow for additional entry points or leaking sensitive information.
10-
As such, debugging should only be enabled during development, and disabled in production builds.</p>
9+
<p>You should only enable debugging features during development. When you create a production build, you should disable it. If you enable debugging features, this can make your code vulnerable by adding entry points, or leaking sensitive information.
1110
</overview>
1211
<recommendation>
1312
<p>Ensure that debugging features are not enabled in production builds.
@@ -16,7 +15,7 @@ If <code>WebView.setWebContentsDebuggingEnabled(true)</code> is used, ensure tha
1615
</recommendation>
1716
<example>
1817

19-
<p>In the code below, the BAD case shows WebView debugging always being enabled,
18+
<p>In the first (bad) example, WebView debugging is always enabled.
2019
whereas the GOOD case only enables it if the <code>android:debuggable</code> attribute is set to <code>true</code>.</p>
2120

2221
<sample src="WebviewDebuggingEnabled.java" />

java/ql/src/Security/CWE/CWE-489/WebviewDebuggingEnabled.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/**
22
* @name Android Webview debugging enabled
3-
* @description Webview debugging should not be enabled in production builds.
3+
* @description Enabling Webview debugging in production builds can expose entry points or leak sensitive information.
44
* @kind path-problem
55
* @problem.severity warning
66
* @security-severity 7.2

0 commit comments

Comments
 (0)