Skip to content

Commit 42a3d8c

Browse files
committed
JS: Treat Member[x] as a language-specific token
In Ruby it is ambiguous whether Member[foo] means x.foo or x::foo
1 parent acf95d6 commit 42a3d8c

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

javascript/ql/lib/semmle/javascript/frameworks/data/internal/ApiGraphModels.qll

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -275,9 +275,6 @@ API::Node getSuccessorFromNode(API::Node node, AccessPathToken token) {
275275
token.getName() = ["Argument", "Parameter"] and
276276
result = node.getParameter(getAnIntFromStringUnbounded(token.getAnArgument()))
277277
or
278-
token.getName() = "Member" and
279-
result = node.getMember(token.getAnArgument())
280-
or
281278
token.getName() = "ReturnValue" and
282279
result = node.getReturn()
283280
or

javascript/ql/lib/semmle/javascript/frameworks/data/internal/ApiGraphModelsSpecific.qll

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,9 @@ API::Node getExtraNodeFromPath(string package, string type, AccessPath path, int
8989
*/
9090
bindingset[token]
9191
API::Node getExtraSuccessorFromNode(API::Node node, AccessPathToken token) {
92+
token.getName() = "Member" and
93+
result = node.getMember(token.getAnArgument())
94+
or
9295
token.getName() = "Instance" and
9396
result = node.getInstance()
9497
or

0 commit comments

Comments
 (0)