C#: Use generic TryParse method instead.

michaelnebel · michaelnebel · commit 3e898a1b098e · 2022-02-24T16:18:42.000+01:00
diff --git a/csharp/extractor/Semmle.Extraction/Options.cs b/csharp/extractor/Semmle.Extraction/Options.cs
@@ -67,15 +67,12 @@ public virtual bool HandleOption(string key, string value)
                     Verbosity = (Verbosity)int.Parse(value);
                     return true;
                 case "compression":
-                    try
+                    if (Enum.TryParse<TrapWriter.CompressionMode>(value, true, out var mode))
                     {
-                        TrapCompression = (TrapWriter.CompressionMode)Enum.Parse(typeof(TrapWriter.CompressionMode), value, true);
+                        TrapCompression = mode;
                         return true;
                     }
-                    catch (ArgumentException)
-                    {
-                        return false;
-                    }
+                    return false;
                 default:
                     return false;
             }

Original file line number	Diff line number	Diff line change
`@@ -67,15 +67,12 @@ public virtual bool HandleOption(string key, string value)`
`67`	`67`	`Verbosity = (Verbosity)int.Parse(value);`
`68`	`68`	`return true;`
`69`	`69`	`case "compression":`
`70`		`- try`
	`70`	`+ if (Enum.TryParse<TrapWriter.CompressionMode>(value, true, out var mode))`
`71`	`71`	`{`
`72`		`- TrapCompression = (TrapWriter.CompressionMode)Enum.Parse(typeof(TrapWriter.CompressionMode), value, true);`
	`72`	`+ TrapCompression = mode;`
`73`	`73`	`return true;`
`74`	`74`	`}`
`75`		`- catch (ArgumentException)`
`76`		`- {`
`77`		`- return false;`
`78`		`- }`
	`75`	`+ return false;`
`79`	`76`	`default:`
`80`	`77`	`return false;`
`81`	`78`	`}`