Skip to content

Commit 3c6c09b

Browse files
committed
No longer require a mode in Cipher.init
1 parent 75f6209 commit 3c6c09b

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

java/ql/lib/semmle/code/java/security/StaticInitializationVectorQuery.qll

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -95,17 +95,15 @@ private class StaticInitializationVectorSource extends DataFlow::Node {
9595
}
9696

9797
/**
98-
* A sink that initializes a cipher for encryption with unsafe parameters.
98+
* A sink that initializes a cipher with unsafe parameters.
9999
*/
100100
private class EncryptionInitializationSink extends DataFlow::Node {
101101
EncryptionInitializationSink() {
102-
exists(MethodAccess ma, Method m, FieldRead fr | m = ma.getMethod() |
102+
exists(MethodAccess ma, Method m | m = ma.getMethod() |
103103
m.hasQualifiedName("javax.crypto", "Cipher", "init") and
104104
m.getParameterType(2)
105105
.(RefType)
106106
.hasQualifiedName("java.security.spec", "AlgorithmParameterSpec") and
107-
fr.getField().hasQualifiedName("javax.crypto", "Cipher", "ENCRYPT_MODE") and
108-
DataFlow::localExprFlow(fr, ma.getArgument(0)) and
109107
ma.getArgument(2) = this.asExpr()
110108
)
111109
}

0 commit comments

Comments
 (0)