Skip to content

Commit 3b0066e

Browse files
committed
address review comments
1 parent ad33997 commit 3b0066e

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

javascript/ql/lib/semmle/javascript/PackageExports.qll

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -117,11 +117,10 @@ private DataFlow::Node getAValueExportedByPackage() {
117117
// }));
118118
// ```
119119
// Such files are not recognized as modules, so we manually use `NodeModule::resolveMainModule` to resolve the file against a `package.json` file.
120-
exists(ImmediatelyInvokedFunctionExpr func, DataFlow::ParameterNode prev, int i |
121-
prev.getName() = "factory" and
122-
func.getParameter(i) = prev.getParameter() and
123-
DataFlow::globalVarRef("define").getACall().getArgument(any(int a | a >= 1)) =
124-
prev.getALocalUse() and
120+
exists(ImmediatelyInvokedFunctionExpr func, DataFlow::ParameterNode factory, int i |
121+
factory.getName() = "factory" and
122+
func.getParameter(i) = factory.getParameter() and
123+
DataFlow::globalVarRef("define").getACall().getAnArgument() = factory.getALocalUse() and
125124
func.getFile() =
126125
min(int j, File f |
127126
f = NodeModule::resolveMainModule(any(PackageJSON pack | exists(pack.getPackageName())), j)

0 commit comments

Comments
 (0)