Skip to content

Commit 33b508d

Browse files
committed
Python: undo change to --max-import-depth
This is not necessary as long as `LibraryCall` only includes unresolved calls.
1 parent 245baa5 commit 33b508d

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

python/ql/lib/semmle/python/dataflow/new/internal/DataFlowDispatchPointsTo.qll

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -612,9 +612,10 @@ class SpecialCall extends DataFlowSourceCall, TSpecialCall {
612612
/**
613613
* A call to a summarized callable, a `LibraryCallable`.
614614
*
615-
* This is a potential call, really. It has an empty charpred, so any `CallNode` is allowed.
616-
* It is here to stake out territory, as otherwise a call to `map` would be considered a `ClassCall`
617-
* and not be available for a summary.
615+
* We currently exclude all resolved calls. This means that a call to, say, `map`, which
616+
* is a `ClassCall`, cannot currently be given a summary.
617+
* We hope to lift this restriction in the future and include all potential calls to summaries
618+
* in this class.
618619
*/
619620
class LibraryCall extends NormalCall {
620621
LibraryCall() {
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
semmle-extractor-options: --lang=3 --max-import-depth=0
1+
semmle-extractor-options: --lang=3 --max-import-depth=1

0 commit comments

Comments
 (0)