Skip to content

Commit 3184ddb

Browse files
committed
JS: Fix test case
1 parent 3410dd5 commit 3184ddb

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

javascript/ql/test/query-tests/Security/CWE-843/TypeConfusionThroughParameterTampering.expected

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,13 @@ nodes
4444
| tst.js:98:9:98:16 | data.foo |
4545
| tst.js:98:9:98:16 | data.foo |
4646
| tst.js:98:9:98:16 | data.foo |
47+
| tst.js:103:9:103:29 | data |
48+
| tst.js:103:16:103:29 | req.query.data |
49+
| tst.js:103:16:103:29 | req.query.data |
50+
| tst.js:105:9:105:12 | data |
51+
| tst.js:105:9:105:12 | data |
52+
| tst.js:107:9:107:12 | data |
53+
| tst.js:107:9:107:12 | data |
4754
edges
4855
| tst.js:5:9:5:27 | foo | tst.js:6:5:6:7 | foo |
4956
| tst.js:5:9:5:27 | foo | tst.js:6:5:6:7 | foo |
@@ -79,6 +86,12 @@ edges
7986
| tst.js:92:9:92:16 | data.foo | tst.js:92:9:92:16 | data.foo |
8087
| tst.js:95:9:95:16 | data.foo | tst.js:95:9:95:16 | data.foo |
8188
| tst.js:98:9:98:16 | data.foo | tst.js:98:9:98:16 | data.foo |
89+
| tst.js:103:9:103:29 | data | tst.js:105:9:105:12 | data |
90+
| tst.js:103:9:103:29 | data | tst.js:105:9:105:12 | data |
91+
| tst.js:103:9:103:29 | data | tst.js:107:9:107:12 | data |
92+
| tst.js:103:9:103:29 | data | tst.js:107:9:107:12 | data |
93+
| tst.js:103:16:103:29 | req.query.data | tst.js:103:9:103:29 | data |
94+
| tst.js:103:16:103:29 | req.query.data | tst.js:103:9:103:29 | data |
8295
#select
8396
| tst.js:6:5:6:7 | foo | tst.js:5:15:5:27 | req.query.foo | tst.js:6:5:6:7 | foo | Potential type confusion as $@ may be either an array or a string. | tst.js:5:15:5:27 | req.query.foo | this HTTP request parameter |
8497
| tst.js:8:5:8:7 | foo | tst.js:5:15:5:27 | req.query.foo | tst.js:8:5:8:7 | foo | Potential type confusion as $@ may be either an array or a string. | tst.js:5:15:5:27 | req.query.foo | this HTTP request parameter |
@@ -95,3 +108,5 @@ edges
95108
| tst.js:92:9:92:16 | data.foo | tst.js:92:9:92:16 | data.foo | tst.js:92:9:92:16 | data.foo | Potential type confusion as $@ may be either an array or a string. | tst.js:92:9:92:16 | data.foo | this HTTP request parameter |
96109
| tst.js:95:9:95:16 | data.foo | tst.js:95:9:95:16 | data.foo | tst.js:95:9:95:16 | data.foo | Potential type confusion as $@ may be either an array or a string. | tst.js:95:9:95:16 | data.foo | this HTTP request parameter |
97110
| tst.js:98:9:98:16 | data.foo | tst.js:98:9:98:16 | data.foo | tst.js:98:9:98:16 | data.foo | Potential type confusion as $@ may be either an array or a string. | tst.js:98:9:98:16 | data.foo | this HTTP request parameter |
111+
| tst.js:105:9:105:12 | data | tst.js:103:16:103:29 | req.query.data | tst.js:105:9:105:12 | data | Potential type confusion as $@ may be either an array or a string. | tst.js:103:16:103:29 | req.query.data | this HTTP request parameter |
112+
| tst.js:107:9:107:12 | data | tst.js:103:16:103:29 | req.query.data | tst.js:107:9:107:12 | data | Potential type confusion as $@ may be either an array or a string. | tst.js:103:16:103:29 | req.query.data | this HTTP request parameter |

javascript/ql/test/query-tests/Security/CWE-843/tst.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ express().get('/foo', function (req, res) {
100100
});
101101

102102
express().get('/foo', function (req, res) {
103-
let data = req.query;
103+
let data = req.query.data;
104104
if (Array.isArray(data)) {
105105
data.indexOf(); // OK
106106
} else {

0 commit comments

Comments
 (0)