C++: Extend getFunction to handle orphaned local variables

jketema · jketema · commit 309fecac9270 · 2022-08-19T15:22:30.000+02:00
diff --git a/cpp/ql/lib/semmle/code/cpp/Variable.qll b/cpp/ql/lib/semmle/code/cpp/Variable.qll
@@ -398,6 +398,8 @@ class LocalVariable extends LocalScopeVariable, @localvariable {
     exists(DeclStmt s | s.getADeclaration() = this and s.getEnclosingFunction() = result)
     or
     exists(ConditionDeclExpr e | e.getVariable() = this and e.getEnclosingFunction() = result)
+    or
+    orphaned_variables(underlyingElement(this), unresolveElement(result))
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -398,6 +398,8 @@ class LocalVariable extends LocalScopeVariable, @localvariable {`
`398`	`398`	`exists(DeclStmt s \| s.getADeclaration() = this and s.getEnclosingFunction() = result)`
`399`	`399`	`or`
`400`	`400`	`exists(ConditionDeclExpr e \| e.getVariable() = this and e.getEnclosingFunction() = result)`
	`401`	`+ or`
	`402`	`+ orphaned_variables(underlyingElement(this), unresolveElement(result))`
`401`	`403`	`}`
`402`	`404`	`}`
`403`	`405`