Merge pull request #9856 from tausbn/python-fix-bad-ScopeEntryDefinition-charpred-join

yoff · web-flow · commit 3006fa60c6d4 · 2022-08-16T14:37:53.000+02:00
Python: Fix bad join in `ScopeEntryDefinition`
diff --git a/python/ql/lib/semmle/python/essa/Essa.qll b/python/ql/lib/semmle/python/essa/Essa.qll
@@ -632,7 +632,8 @@ class DeletionDefinition extends EssaNodeDefinition {
  */
 class ScopeEntryDefinition extends EssaNodeDefinition {
   ScopeEntryDefinition() {
-    this.getDefiningNode() = this.getSourceVariable().getScopeEntryDefinition() and
+    this.getDefiningNode() =
+      pragma[only_bind_out](this.getSourceVariable()).getScopeEntryDefinition() and
     not this instanceof ImplicitSubModuleDefinition
   }
 

Original file line number	Diff line number	Diff line change
`@@ -632,7 +632,8 @@ class DeletionDefinition extends EssaNodeDefinition {`
`632`	`632`	`*/`
`633`	`633`	`class ScopeEntryDefinition extends EssaNodeDefinition {`
`634`	`634`	`ScopeEntryDefinition() {`
`635`		`- this.getDefiningNode() = this.getSourceVariable().getScopeEntryDefinition() and`
	`635`	`+ this.getDefiningNode() =`
	`636`	`+ pragma[only_bind_out](this.getSourceVariable()).getScopeEntryDefinition() and`
`636`	`637`	`not this instanceof ImplicitSubModuleDefinition`
`637`	`638`	`}`
`638`	`639`