Skip to content

Commit 276f8d4

Browse files
committed
Ruby: add comments to address review feedback
1 parent 00bf352 commit 276f8d4

File tree

1 file changed

+3
-3
lines changed
  • ruby/ql/lib/codeql/ruby/frameworks/core

1 file changed

+3
-3
lines changed

ruby/ql/lib/codeql/ruby/frameworks/core/Array.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ module Array {
199199
/** A call to `[]`, or its alias, `slice`. */
200200
abstract private class ElementReferenceReadSummary extends SummarizedCallable {
201201
MethodCall mc;
202-
ElementReferenceReadMethodName methodName;
202+
ElementReferenceReadMethodName methodName; // adding this as a field helps give a better join order
203203

204204
bindingset[this]
205205
ElementReferenceReadSummary() { mc.getMethodName() = methodName }
@@ -2018,7 +2018,7 @@ module Enumerable {
20182018

20192019
abstract private class GrepSummary extends SummarizedCallable {
20202020
MethodCall mc;
2021-
GrepMethodName methodName;
2021+
GrepMethodName methodName; // adding this as a field helps give a better join order
20222022

20232023
bindingset[this]
20242024
GrepSummary() { mc.getMethodName() = methodName }
@@ -2162,7 +2162,7 @@ module Enumerable {
21622162

21632163
abstract private class MinOrMaxSummary extends SummarizedCallable {
21642164
MethodCall mc;
2165-
MinOrMaxMethodName methodName;
2165+
MinOrMaxMethodName methodName; // adding this as a field helps give a better join order
21662166

21672167
bindingset[this]
21682168
MinOrMaxSummary() { mc.getMethodName() = methodName }

0 commit comments

Comments
 (0)