Ruby: Simplify getKeywordArgumentIncludeHashArgument

RasmusWL · RasmusWL · commit 25d09cd6d6ea · 2022-09-06T10:24:22.000+02:00
As suggested by @hvitved in review
diff --git a/ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowPublic.qll b/ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowPublic.qll
@@ -118,7 +118,7 @@ class CallNode extends LocalSourceNode, ExprNode {
             .asExpr()
             .(CfgNodes::ExprNodes::HashLiteralCfgNode)
             .getAKeyValuePair() and
-      exprNode(pair.getKey()).getALocalSource().asExpr().getConstantValue().isStringlikeValue(name) and
+      pair.getKey().getConstantValue().isStringlikeValue(name) and
       result.asExpr() = pair.getValue()
     )
   }

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ class CallNode extends LocalSourceNode, ExprNode {`
`118`	`118`	`.asExpr()`
`119`	`119`	`.(CfgNodes::ExprNodes::HashLiteralCfgNode)`
`120`	`120`	`.getAKeyValuePair() and`
`121`		`- exprNode(pair.getKey()).getALocalSource().asExpr().getConstantValue().isStringlikeValue(name) and`
	`121`	`+ pair.getKey().getConstantValue().isStringlikeValue(name) and`
`122`	`122`	`result.asExpr() = pair.getValue()`
`123`	`123`	`)`
`124`	`124`	`}`