Skip to content

Commit 24750dc

Browse files
committed
Ruby: Sync comment for self API graph label
1 parent 2ad4921 commit 24750dc

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

ruby/ql/lib/codeql/ruby/ApiGraphs.qll

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -793,13 +793,11 @@ module API {
793793
or
794794
pos.isAnyNamed() and
795795
result = Label::keywordParameter(_)
796+
//
796797
// Note: there is currently no API graph label for `self`.
797798
// It was omitted since in practice it means going back to where you came from.
798799
// For example, `base.getMethod("foo").getSelf()` would just be `base`.
799800
// However, it's possible we'll need it later, for identifying `self` parameters or post-update nodes.
800-
// or
801-
// pos.isSelf() and
802-
// ...
803801
}
804802

805803
/** Gets the API graph label corresponding to the given parameter position. */
@@ -829,10 +827,11 @@ module API {
829827
or
830828
pos.isAnyNamed() and
831829
result = Label::keywordParameter(_)
832-
// TODO: needs handling of `self` ParameterPosition
833-
// or
834-
// pos.isSelf() and
835-
// ...
830+
//
831+
// Note: there is currently no API graph label for `self`.
832+
// It was omitted since in practice it means going back to where you came from.
833+
// For example, `base.getMethod("foo").getSelf()` would just be `base`.
834+
// However, it's possible we'll need it later, for identifying `self` parameters or post-update nodes.
836835
}
837836
}
838837
}

0 commit comments

Comments
 (0)