Skip to content

Commit 101ad77

Browse files
committed
Move things around after rebase
1 parent 0302058 commit 101ad77

File tree

4 files changed

+5
-376
lines changed

4 files changed

+5
-376
lines changed

java/ql/lib/semmle/code/java/frameworks/Networking.qll

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ class SocketGetInputStreamMethod extends Method {
4747
}
4848
}
4949

50+
/** The method `java.net.Socket::getOutputStream`. */
5051
class SocketGetOutputStreamMethod extends Method {
5152
SocketGetOutputStreamMethod() {
5253
this.getDeclaringType() instanceof TypeSocket and
@@ -164,6 +165,7 @@ class CreateSocketMethod extends Method {
164165
}
165166
}
166167

168+
/** The method `javax.net.Socket::connect`. */
167169
class SocketConnectMethod extends Method {
168170
SocketConnectMethod() {
169171
this.hasName("connect") and

java/ql/lib/semmle/code/java/security/Encryption.qll

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,12 @@ class SSLSession extends RefType {
3434
SSLSession() { this.hasQualifiedName("javax.net.ssl", "SSLSession") }
3535
}
3636

37+
/** The `javax.net.ssl.SSLEngine` class. */
3738
class SSLEngine extends RefType {
3839
SSLEngine() { this.hasQualifiedName("javax.net.ssl", "SSLEngine") }
3940
}
4041

42+
/** The `javax.net.ssl.SSLSocket` class. */
4143
class SSLSocket extends RefType {
4244
SSLSocket() { this.hasQualifiedName("javax.net.ssl", "SSLSocket") }
4345
}
@@ -221,7 +223,7 @@ string getInsecureAlgorithmRegex() {
221223
string getASecureAlgorithmName() {
222224
result =
223225
[
224-
"RSA", "SHA256", "SHA512", "CCM", "GCM", "AES([^a-zA-Z](?!ECB|CBC/PKCS[57]Padding)).*",
226+
"RSA", "SHA256", "SHA512", "CCM", "GCM", "AES(?![^a-zA-Z](ECB|CBC/PKCS[57]Padding))",
225227
"Blowfish", "ECIES"
226228
]
227229
}

0 commit comments

Comments
 (0)