Skip to content

Commit 0e62d6f

Browse files
committed
Swift: update extractor to new IfConfigDecl
1 parent 7ae68fc commit 0e62d6f

File tree

5 files changed

+1
-19
lines changed

5 files changed

+1
-19
lines changed

swift/extractor/infra/SwiftDispatcher.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ class SwiftDispatcher {
2929
const swift::Pattern*,
3030
const swift::TypeRepr*,
3131
const swift::TypeBase*,
32-
const swift::IfConfigClause*,
3332
FilePath>;
3433

3534
template <typename E>
@@ -323,7 +322,6 @@ class SwiftDispatcher {
323322
// as we don't expect `nullptr` here. However `swift::ASTVisitor` and `swift::TypeVisitor` do not
324323
// accept const pointers
325324
virtual void visit(swift::Decl* decl) = 0;
326-
virtual void visit(const swift::IfConfigClause* clause) = 0;
327325
virtual void visit(swift::Stmt* stmt) = 0;
328326
virtual void visit(const swift::StmtCondition* cond) = 0;
329327
virtual void visit(const swift::StmtConditionElement* cond) = 0;

swift/extractor/infra/SwiftTagTraits.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ MAP_TAG(Argument);
4949
#include <swift/AST/ExprNodes.def>
5050

5151
MAP_TAG(Decl);
52-
MAP_TAG(IfConfigClause);
5352
#define ABSTRACT_DECL(CLASS, PARENT) MAP_SUBTAG(CLASS##Decl, PARENT)
5453
#define DECL(CLASS, PARENT) ABSTRACT_DECL(CLASS, PARENT)
5554
#include <swift/AST/DeclNodes.def>

swift/extractor/visitors/DeclVisitor.cpp

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -380,19 +380,10 @@ void DeclVisitor::fillAbstractStorageDecl(const swift::AbstractStorageDecl& decl
380380

381381
codeql::IfConfigDecl DeclVisitor::translateIfConfigDecl(const swift::IfConfigDecl& decl) {
382382
auto entry = createEntry(decl);
383-
// entry.clauses = dispatcher_.fetchRepeatedLabels(decl.getClauses());
384383
if (auto activeClause = decl.getActiveClause()) {
385-
entry.clauses.push_back(dispatcher_.fetchLabel(activeClause));
384+
entry.active_elements = dispatcher_.fetchRepeatedLabels(activeClause->Elements);
386385
}
387386
return entry;
388387
}
389388

390-
codeql::IfConfigClause DeclVisitor::translateIfConfigClause(const swift::IfConfigClause& clause) {
391-
auto entry = dispatcher_.createEntry(clause);
392-
// entry.condition = dispatcher_.fetchOptionalLabel(clause.Cond);
393-
entry.elements = dispatcher_.fetchRepeatedLabels(clause.Elements);
394-
entry.is_active = clause.isActive;
395-
return entry;
396-
}
397-
398389
} // namespace codeql

swift/extractor/visitors/DeclVisitor.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@ class DeclVisitor : public AstVisitorBase<DeclVisitor> {
1616
using AstVisitorBase<DeclVisitor>::AstVisitorBase;
1717
using AstVisitorBase<DeclVisitor>::visit;
1818

19-
void visit(const swift::IfConfigClause* clause) {
20-
dispatcher_.emit(translateIfConfigClause(*clause));
21-
}
22-
2319
std::optional<codeql::ConcreteFuncDecl> translateFuncDecl(const swift::FuncDecl& decl);
2420
std::optional<codeql::ConstructorDecl> translateConstructorDecl(
2521
const swift::ConstructorDecl& decl);
@@ -50,7 +46,6 @@ class DeclVisitor : public AstVisitorBase<DeclVisitor> {
5046
codeql::ImportDecl translateImportDecl(const swift::ImportDecl& decl);
5147
std::optional<codeql::ModuleDecl> translateModuleDecl(const swift::ModuleDecl& decl);
5248
codeql::IfConfigDecl translateIfConfigDecl(const swift::IfConfigDecl& decl);
53-
codeql::IfConfigClause translateIfConfigClause(const swift::IfConfigClause& clause);
5449

5550
private:
5651
std::string mangledName(const swift::ValueDecl& decl);

swift/extractor/visitors/SwiftVisitor.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ class SwiftVisitor : private SwiftDispatcher {
2222

2323
private:
2424
void visit(swift::Decl* decl) override { declVisitor.visit(decl); }
25-
void visit(const swift::IfConfigClause* clause) override { declVisitor.visit(clause); }
2625
void visit(swift::Stmt* stmt) override { stmtVisitor.visit(stmt); }
2726
void visit(const swift::StmtCondition* cond) override {
2827
emit(stmtVisitor.translateStmtCondition(*cond));

0 commit comments

Comments
 (0)