Skip to content

Commit 00b0a6b

Browse files
Jami Cogswellatorralba
authored andcommitted
update act tests
1 parent 834927c commit 00b0a6b

File tree

1 file changed

+1
-30
lines changed

1 file changed

+1
-30
lines changed

java/ql/test/library-tests/frameworks/android/intent/TestStartActivityToGetIntent.java

Lines changed: 1 addition & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -12,30 +12,17 @@ static void sink(Object sink) {}
1212

1313
public void test(Context ctx, Activity act) {
1414

15-
// test all methods that start an activity
15+
// test methods that start an activity
1616
{
1717
Intent intent = new Intent(null, SomeActivity.class);
1818
intent.putExtra("data", (String) source("ctx-start"));
1919
ctx.startActivity(intent);
2020
}
21-
{
22-
// Intent intent1 = new Intent(null, SomeActivity2.class);
23-
// intent1.putExtra("data", (String) source("ctx-starts"));
24-
// Intent intent2 = new Intent(null, SomeActivity3.class);
25-
// intent2.putExtra("data", (String) source("ctx-starts"));
26-
// Intent[] intents = {intent1, intent2};
27-
// ctx.startActivities(intents);
28-
}
2921
{
3022
Intent intent = new Intent(null, SomeActivity.class);
3123
intent.putExtra("data", (String) source("act-start"));
3224
act.startActivity(intent);
3325
}
34-
{
35-
// Intent[] intent = {new Intent(null, SomeActivity.class)};
36-
// intent[0].putExtra("data", (String) source("act-starts"));
37-
// act.startActivities(intent);
38-
}
3926
{
4027
Intent intent = new Intent(null, SomeActivity.class);
4128
intent.putExtra("data", (String) source("start-for-result"));
@@ -85,22 +72,6 @@ public void test() {
8572

8673
}
8774

88-
// static class SomeActivity2 extends Activity {
89-
90-
// public void test() {
91-
// sink(getIntent().getStringExtra("data")); // $ hasValueFlow=ctx-starts
92-
// }
93-
94-
// }
95-
96-
// static class SomeActivity3 extends Activity {
97-
98-
// public void test() {
99-
// sink(getIntent().getStringExtra("data")); // $ hasValueFlow=ctx-starts
100-
// }
101-
102-
// }
103-
10475
static class SafeActivity extends Activity {
10576

10677
public void test() {

0 commit comments

Comments
 (0)