Scope: improve user declaration definition

knewbury01 · knewbury01 · commit edf41d575362 · 2024-03-25T23:02:11.000-04:00
diff --git a/cpp/common/src/codingstandards/cpp/Scope.qll b/cpp/common/src/codingstandards/cpp/Scope.qll
@@ -67,6 +67,8 @@ class UserDeclaration extends Declaration {
     not this.(Variable).isCompilerGenerated() and
     not this.(Function).isCompilerGenerated() and
     not this.(Parameter).getFunction().isCompilerGenerated() and
+    // will falsely conflict
+    not this instanceof ClassTemplateInstantiation and
     // compiler inferred parameters have name of p#0
     not this.(Parameter).getName() = "p#0"
   }

Original file line number	Diff line number	Diff line change
`@@ -67,6 +67,8 @@ class UserDeclaration extends Declaration {`
`67`	`67`	`not this.(Variable).isCompilerGenerated() and`
`68`	`68`	`not this.(Function).isCompilerGenerated() and`
`69`	`69`	`not this.(Parameter).getFunction().isCompilerGenerated() and`
	`70`	`+ // will falsely conflict`
	`71`	`+ not this instanceof ClassTemplateInstantiation and`
`70`	`72`	`// compiler inferred parameters have name of p#0`
`71`	`73`	`not this.(Parameter).getName() = "p#0"`
`72`	`74`	`}`