A7-1-5: Ignore inits of a non-fundamental type

Author: lcartey

cpp/autosar/src/rules/A7-1-5/AutoSpecifierNotUsedAppropriatelyInVariableDefinition.ql

@@ -19,6 +19,10 @@
 import cpp
 import codingstandards.cpp.autosar
 
+class FundamentalType extends BuiltInType {
+  FundamentalType() { not this instanceof ErroneousType and not this instanceof UnknownType }
+}
+
 from Variable v
 where
   not isExcluded(v,
@@ -28,12 +32,14 @@ where
   // exclude uninstantiated templates and rely on the instantiated templates, because an uninstantiated template may not contain the information required to determine if the usage is allowed.
   not v.isFromUninstantiatedTemplate(_) and
   not (
-    // find ones where
+    // Initialized by function call
     v.getInitializer().getExpr() instanceof FunctionCall
     or
+    // Initialized by lambda expression
     v.getInitializer().getExpr() instanceof LambdaExpression
     or
-    v.getInitializer().getExpr() instanceof ClassAggregateLiteral
+    // Initialized by non-fundamental type
+    not v.getInitializer().getExpr().getType() instanceof FundamentalType
   ) and
   // Exclude compiler generated variables
   not v.isCompilerGenerated()

cpp/autosar/test/rules/A7-1-5/test.cpp

@@ -108,7 +108,13 @@ void instantiate() {
 }
 
 void test_loop() {
-  for (const auto a : {8, 9, 10}) {
+  for (const auto a : {8, 9, 10}) { // NON_COMPLIANT - a is initialized with a
+                                    // non-constant initializer
+    a;
+  }
+
+  std::vector<int> v = {1, 2, 3};
+  for (const auto a : v) { // COMPLIANT - a is intialized with a function call
     a;
   }
 }