Extract ArithmeticOperation to Expr.qll.

Author: lcartey

cpp/autosar/src/rules/M5-2-10/IncrementAndDecrementOperatorsMixedWithOtherOperatorsInExpression.ql

@@ -16,12 +16,7 @@
 
 import cpp
 import codingstandards.cpp.autosar
-
-class ArithmeticOperation extends Operation {
-  ArithmeticOperation() {
-    this instanceof UnaryArithmeticOperation or this instanceof BinaryArithmeticOperation
-  }
-}
+import codingstandards.cpp.Expr
 
 from CrementOperation cop, ArithmeticOperation op, string name
 where

cpp/common/src/codingstandards/cpp/Expr.qll

@@ -2,6 +2,15 @@ import cpp
 private import semmle.code.cpp.valuenumbering.GlobalValueNumbering
 import codingstandards.cpp.AccessPath
 
+/**
+ * A unary or binary arithmetic operation.
+ */
+class ArithmeticOperation extends Operation {
+  ArithmeticOperation() {
+    this instanceof UnaryArithmeticOperation or this instanceof BinaryArithmeticOperation
+  }
+}
+
 /** A full expression as defined in [intro.execution] of N3797. */
 class FullExpr extends Expr {
   FullExpr() {