M5-3-3: Excude binary operators.

Rule only applies to the unary operator&.

Author: lcartey

change_notes/2024-01-14-m5-3-3-exclude-binary.md

@@ -0,0 +1 @@
+ * `M5-3-3` - exclude binary user defined `operator&` from this rule.

cpp/autosar/src/rules/M5-3-3/UnaryOperatorOverloaded.ql

@@ -15,5 +15,12 @@ import cpp
 import codingstandards.cpp.autosar
 
 from Operator o
-where not isExcluded(o, OperatorsPackage::unaryOperatorOverloadedQuery()) and o.hasName("operator&")
+where
+  not isExcluded(o, OperatorsPackage::unaryOperatorOverloadedQuery()) and
+  o.hasName("operator&") and
+  (
+    if o instanceof MemberFunction
+    then o.getNumberOfParameters() = 0
+    else o.getNumberOfParameters() = 1
+  )
 select o, "The unary & operator overloaded."

cpp/autosar/test/rules/M5-3-3/UnaryOperatorOverloaded.expected

@@ -1 +1,2 @@
-| test.cpp:6:5:6:13 | operator& | The unary & operator overloaded. |
+| test.cpp:2:5:2:13 | operator& | The unary & operator overloaded. |
+| test.cpp:8:3:8:11 | operator& | The unary & operator overloaded. |

cpp/autosar/test/rules/M5-3-3/test.cpp

@@ -1,7 +1,9 @@
-/* The unary & operator shall not be overloaded */
-// do not defined it at all
-class A
-
-{
-  A operator&(); // NON_COMPLIANT
+class A {
+  A operator&();                      // NON_COMPLIANT - unary
+  constexpr A operator&(const A rhs); // COMPLIANT - binary
 };
+
+class B {};
+
+B operator&(B b);                                // NON_COMPLIANT - unary
+constexpr B operator&(const B lhs, const B rhs); // COMPLIANT - binary