Rule 14.4: Convert to non-shared queries

This rule requires the use of the MISRA only essential types library.
This is because in C comparison expressions do not natively have
boolean type.

Author: lcartey

c/common/test/rules/nonbooleanifstmt/NonBooleanIfStmt.expected

@@ -13,10 +13,15 @@
 
 import cpp
 import codingstandards.c.misra
-import codingstandards.cpp.rules.nonbooleanifstmt.NonBooleanIfStmt
+import codingstandards.c.misra.EssentialTypes
 
-class NonBooleanIfConditionQuery extends NonBooleanIfStmtSharedQuery {
-  NonBooleanIfConditionQuery() {
-    this = Statements4Package::nonBooleanIfConditionQuery()
-  }
-}
+from Expr condition, Type essentialType
+where
+  not isExcluded(condition, Statements4Package::nonBooleanIfConditionQuery()) and
+  exists(IfStmt ifStmt |
+    not ifStmt.isFromUninstantiatedTemplate(_) and
+    condition = ifStmt.getCondition() and
+    essentialType = getEssentialType(ifStmt.getCondition()) and
+    not getEssentialTypeCategory(essentialType) = EssentiallyBooleanType()
+  )
+select condition, "If condition has non boolean essential type " + essentialType + "."

c/common/test/rules/nonbooleanifstmt/NonBooleanIfStmt.ql

@@ -13,10 +13,24 @@
 
 import cpp
 import codingstandards.c.misra
-import codingstandards.cpp.rules.nonbooleaniterationstmt.NonBooleanIterationStmt
+import codingstandards.c.misra.EssentialTypes
 
-class NonBooleanIterationConditionQuery extends NonBooleanIterationStmtSharedQuery {
-  NonBooleanIterationConditionQuery() {
-    this = Statements4Package::nonBooleanIterationConditionQuery()
-  }
+/** A macro within the source location of this project. */
+class UserProvidedMacro extends Macro {
+  UserProvidedMacro() { exists(this.getFile().getRelativePath()) }
 }
+
+/** A macro defined within a library used by this project. */
+class LibraryMacro extends Macro {
+  LibraryMacro() { not this instanceof UserProvidedMacro }
+}
+
+from Expr condition, Loop l, Type essentialType
+where
+  not isExcluded(condition, Statements4Package::nonBooleanIterationConditionQuery()) and
+  // Exclude loops generated from library macros
+  not l = any(LibraryMacro lm).getAnInvocation().getAGeneratedElement() and
+  condition = l.getCondition() and
+  essentialType = getEssentialType(condition) and
+  not getEssentialTypeCategory(essentialType) = EssentiallyBooleanType()
+select condition, "Iteration condition has non boolean type " + essentialType + "."

c/common/test/rules/nonbooleaniterationstmt/NonBooleanIterationStmt.expected

@@ -0,0 +1,3 @@
+| test.c:7:7:7:8 | l1 | If condition has non boolean essential type int. |
+| test.c:9:7:9:8 | call to f1 | If condition has non boolean essential type int. |
+| test.c:12:7:12:8 | l2 | If condition has non boolean essential type void *. |

c/common/test/rules/nonbooleaniterationstmt/NonBooleanIterationStmt.ql

@@ -0,0 +1 @@
+rules/RULE-14-4/NonBooleanIfCondition.ql

c/misra/src/rules/RULE-14-4/NonBooleanIfCondition.ql

@@ -0,0 +1,2 @@
+| test_iteration.c:5:20:5:20 | i | Iteration condition has non boolean type int. |
+| test_iteration.c:7:10:7:11 | l1 | Iteration condition has non boolean type int. |